From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0542ECA9EAF for ; Thu, 24 Oct 2019 09:07:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C03C220578 for ; Thu, 24 Oct 2019 09:07:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PDWJcV+P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C03C220578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNZ5J-0002Mq-Vk for qemu-devel@archiver.kernel.org; Thu, 24 Oct 2019 05:07:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42991) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNZ3m-0000so-61 for qemu-devel@nongnu.org; Thu, 24 Oct 2019 05:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNZ3l-0000dG-1a for qemu-devel@nongnu.org; Thu, 24 Oct 2019 05:05:34 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:44432) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNZ3k-0000cO-RW; Thu, 24 Oct 2019 05:05:32 -0400 Received: by mail-wr1-x444.google.com with SMTP id z11so1776898wro.11; Thu, 24 Oct 2019 02:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=VAqQalthoG+xbrZURmZhEGl6mSw37NtdImucMDrxq9c=; b=PDWJcV+P+qfaTI4Uk9WRKGz1XZ203NYg01OliYBmrrFXFRzkVXtznWDoTWEZy37umI wL3rKi/e1/qDbBC54UrxrKRT8gjMZn/N7ADbJ2V3AT5TECH/0/w6z7u11xg9muSuZ8WX PB5fSuKU+vW6kPhAp5f4RjQFHdSZ2ni6YCvIqqZnBUmEfsgyLGDg2bY7xnLc4IfNXR1H hIf8aJrKkRo+kWvhAYPlHVXkAvNz3DxdAg1h0n0+2QgxNBFGu2WzK+jolf9aW9VDKBqJ HlXvHSArd2zq4v3xIlLlhv/wyZMemCXS4Jjwy4QhHMZkiHlUp5mhXuuWOfGdOjCLISNR hWJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=VAqQalthoG+xbrZURmZhEGl6mSw37NtdImucMDrxq9c=; b=teDp0nZ4kYqQmbZesGjGEJjJd/pK3zxmCVK9kqLz933BahVuQ11alchYMyrZ1ijHQs 13INZd4uW6w7ghBBD49w/xRaya59tKEd0ve4tkfalv3RUcGIkPrJvfgLOdUV1nDSuyG8 ROX5n+KA8oaQk1390Kbva56lf0pMVaQgg5Iv3Uflj7YDYZjaj0FstK7mO5Z6pAnlVHdq 4G7R0dPk2P0A06yi5ZNisug+KgaQ0gOIckSC9tdPt6KXQTSoECY4n5wo3WlpOcKpuoRr 0Ni0ZpGOce/q/bV1MfQwG54tWqjxzZNvl1NhTNbvvNBKDKwzIhF6nukramQ4kZzULvX4 9gPQ== X-Gm-Message-State: APjAAAWg8ea4r/gmR2hvpA/46PvBZJRnb07SW2W6xVhDrCwv6Oj4nPTh rrmBUX34rUfOyQrLt1r41pT87CCTtnrQEQ== X-Google-Smtp-Source: APXvYqx+LNc8c1dbejTMi3x2WgCZPF7Xq26BOkR01LGOSyAsD30rdEefY2o3905WjtSADwI2gOR7sg== X-Received: by 2002:adf:aacc:: with SMTP id i12mr2796325wrc.15.1571907930926; Thu, 24 Oct 2019 02:05:30 -0700 (PDT) Received: from Icho (x590ef5e8.dyn.telefonica.de. [89.14.245.232]) by smtp.gmail.com with ESMTPSA id w9sm17839792wrt.85.2019.10.24.02.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 02:05:30 -0700 (PDT) Message-ID: Subject: Re: [RFC PATCH 14/14] hw/arm/raspi: Add the Raspberry Pi 4B board From: Esteban Bosse To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Peter Maydell , Andrew Baumann , qemu-devel@nongnu.org, Pekka Enberg , =?ISO-8859-1?Q?Zolt=E1n?= Baldaszti Date: Thu, 24 Oct 2019 11:01:29 +0200 In-Reply-To: <20190904171315.8354-15-f4bug@amsat.org> References: <20190904171315.8354-1-f4bug@amsat.org> <20190904171315.8354-15-f4bug@amsat.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, Clement Deschamps , =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Luc Michel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió: > The Raspberry Pi 4 uses a BCM2711 SoC (based on a BCM2838). > The SoC can handle up to 8GiB of SDRAM, but we limit it to 4GiB > (no 8GiB models in the market yet). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/raspi.c | 31 ++++++++++++++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c > index b4db39661f..59ee2f82b4 100644 > --- a/hw/arm/raspi.c > +++ b/hw/arm/raspi.c > @@ -39,11 +39,13 @@ enum BoardIdChip { > C_BCM2835 = 0, > C_BCM2836 = 1, > C_BCM2837 = 2, > + C_BCM2711 = 3, > }; > > enum BoardIdType { > T_2B = 0x04, > T_3B = 0x08, > + T_4B = 0x11, > }; > > enum BoardIdRevision { > @@ -56,6 +58,7 @@ enum BoardIdRevision { > static const char *processor_typename[] = { > [C_BCM2836] = TYPE_BCM2836, > [C_BCM2837] = TYPE_BCM2837, > + [C_BCM2711] = TYPE_BCM2838, > }; > > typedef struct BoardInfo BoardInfo; > @@ -90,6 +93,12 @@ static const BoardInfo bcm283x_boards[] = { > .ram_size_min = 1 * GiB, > .ram_size_max = 1 * GiB, > }, > + [4] = { > + .board_id = 0xc42, > + .board_rev = { T_4B, R_1_1, C_BCM2711, M_SONY_UK }, > + .ram_size_min = 1 * GiB, > + .ram_size_max = 4 * GiB, > + }, > }; > > typedef struct RasPiState { > @@ -336,4 +345,24 @@ static void raspi3_machine_init(MachineClass > *mc) > mc->default_ram_size = 1 * GiB; > } > DEFINE_MACHINE("raspi3", raspi3_machine_init) > -#endif > + > +static void raspi4_init(MachineState *machine) > +{ > + raspi_init(machine, 4); > +} > + > +static void raspi4_machine_init(MachineClass *mc) > +{ > + mc->desc = "Raspberry Pi 4B"; > + mc->init = raspi4_init; > + mc->block_default_type = IF_SD; > + mc->no_parallel = 1; > + mc->no_floppy = 1; > + mc->no_cdrom = 1; > + mc->max_cpus = BCM283X_NCPUS; > + mc->min_cpus = BCM283X_NCPUS; > + mc->default_cpus = BCM283X_NCPUS; > + mc->default_ram_size = 1 * GiB; > +} > +DEFINE_MACHINE("raspi4", raspi4_machine_init) > +#endif /* TARGET_AARCH64 */ Reviewed-by: Esteban Bosse