From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>,
Jeff Cody <jcody@redhat.com>, John Snow <jsnow@redhat.com>,
Alberto Garcia <berto@igalia.com>
Subject: [Qemu-devel] [PATCH v3 03/11] blockjob: Add block_job_get()
Date: Fri, 1 Jul 2016 18:52:01 +0300 [thread overview]
Message-ID: <ff5e3f4916fdd914a75bc0cf69d0ee537dfe51a9.1467386530.git.berto@igalia.com> (raw)
In-Reply-To: <cover.1467386530.git.berto@igalia.com>
In-Reply-To: <cover.1467386530.git.berto@igalia.com>
Currently the way to look for a specific block job is to iterate the
list manually using block_job_next().
Since we want to be able to identify a job primarily by its ID it
makes sense to have a function that does just that.
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
blockjob.c | 13 +++++++++++++
include/block/blockjob.h | 10 ++++++++++
2 files changed, 23 insertions(+)
diff --git a/blockjob.c b/blockjob.c
index ce0e27c..ca2291b 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -60,6 +60,19 @@ BlockJob *block_job_next(BlockJob *job)
return QLIST_NEXT(job, job_list);
}
+BlockJob *block_job_get(const char *id)
+{
+ BlockJob *job;
+
+ QLIST_FOREACH(job, &block_jobs, job_list) {
+ if (!strcmp(id, job->id)) {
+ return job;
+ }
+ }
+
+ return NULL;
+}
+
/* Normally the job runs in its BlockBackend's AioContext. The exception is
* block_job_defer_to_main_loop() where it runs in the QEMU main loop. Code
* that supports both cases uses this helper function.
diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index 5181514..0fe1540 100644
--- a/include/block/blockjob.h
+++ b/include/block/blockjob.h
@@ -211,6 +211,16 @@ struct BlockJob {
BlockJob *block_job_next(BlockJob *job);
/**
+ * block_job_get:
+ * @id: The id of the block job.
+ *
+ * Get the block job identified by @id (which must not be %NULL).
+ *
+ * Returns the requested job, or %NULL if it doesn't exist.
+ */
+BlockJob *block_job_get(const char *id);
+
+/**
* block_job_create:
* @job_type: The class object for the newly-created job.
* @bs: The block
--
2.8.1
next prev parent reply other threads:[~2016-07-01 15:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 15:51 [Qemu-devel] [PATCH v3 00/11] Allow creating block jobs with a user-defined ID Alberto Garcia
2016-07-01 15:51 ` [Qemu-devel] [PATCH v3 01/11] stream: Fix prototype of stream_start() Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 02/11] blockjob: Update description of the 'id' field Alberto Garcia
2016-07-02 13:47 ` Max Reitz
2016-07-01 15:52 ` Alberto Garcia [this message]
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 04/11] block: Use block_job_get() in find_block_job() Alberto Garcia
2016-07-02 14:02 ` Max Reitz
2016-07-04 13:23 ` Kevin Wolf
2016-07-04 14:05 ` Daniel P. Berrange
2016-07-04 13:35 ` Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 05/11] blockjob: Add 'job_id' parameter to block_job_create() Alberto Garcia
2016-07-02 14:09 ` Max Reitz
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 06/11] mirror: Add 'job-id' parameter to 'blockdev-mirror' and 'drive-mirror' Alberto Garcia
2016-07-02 14:30 ` Max Reitz
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 07/11] backup: Add 'job-id' parameter to 'blockdev-backup' and 'drive-backup' Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 08/11] stream: Add 'job-id' parameter to 'block-stream' Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 09/11] commit: Add 'job-id' parameter to 'block-commit' Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 10/11] qemu-img: Set the ID of the block job in img_commit() Alberto Garcia
2016-07-02 14:21 ` Max Reitz
2016-07-04 12:43 ` Alberto Garcia
2016-07-01 15:52 ` [Qemu-devel] [PATCH v3 11/11] blockjob: Update description of the 'device' field in the QMP API Alberto Garcia
2016-07-02 14:37 ` Max Reitz
2016-07-04 15:49 ` [Qemu-devel] [PATCH v3 00/11] Allow creating block jobs with a user-defined ID Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff5e3f4916fdd914a75bc0cf69d0ee537dfe51a9.1467386530.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).