From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-block@nongnu.org
Subject: Re: [PATCH v2 6/9] util: Share qemu_try_memalign() implementation between POSIX and Windows
Date: Fri, 4 Mar 2022 15:02:26 +0100 [thread overview]
Message-ID: <ff763044-1e6a-18ea-02b9-9f7a7107bf43@gmail.com> (raw)
In-Reply-To: <20220304112126.2261039-7-peter.maydell@linaro.org>
On 4/3/22 12:21, Peter Maydell wrote:
> The qemu_try_memalign() functions for POSIX and Windows used to be
> significantly different, but these days they are identical except for
> the actual allocation function called, and the POSIX version already
> has to have ifdeffery for different allocation functions.
>
> Move to a single implementation in memalign.c, which uses the Windows
> _aligned_malloc if we detect that function in meson.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Message-id: 20220226180723.1706285-7-peter.maydell@linaro.org
> ---
> meson.build | 1 +
> util/memalign.c | 39 +++++++++++++++++++++++++++++++++++++++
> util/oslib-posix.c | 29 -----------------------------
> util/oslib-win32.c | 17 -----------------
> 4 files changed, 40 insertions(+), 46 deletions(-)
Nice.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-03-04 15:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 11:21 [PATCH v2 0/9] Cleanup of qemu_oom_check() and qemu_memalign() Peter Maydell
2022-03-04 11:21 ` [PATCH v2 1/9] hw/usb/redirect.c: Stop using qemu_oom_check() Peter Maydell
2022-03-04 11:21 ` [PATCH v2 2/9] util: Make qemu_oom_check() a static function Peter Maydell
2022-03-04 11:21 ` [PATCH v2 3/9] util: Unify implementations of qemu_memalign() Peter Maydell
2022-03-04 14:00 ` Philippe Mathieu-Daudé
2022-03-04 11:21 ` [PATCH v2 4/9] util: Return valid allocation for qemu_try_memalign() with zero size Peter Maydell
2022-03-04 13:58 ` Philippe Mathieu-Daudé
2022-03-04 20:18 ` Richard Henderson
2022-03-04 11:21 ` [PATCH v2 5/9] meson.build: Don't misdetect posix_memalign() on Windows Peter Maydell
2022-03-05 0:48 ` Philippe Mathieu-Daudé
2022-03-04 11:21 ` [PATCH v2 6/9] util: Share qemu_try_memalign() implementation between POSIX and Windows Peter Maydell
2022-03-04 14:02 ` Philippe Mathieu-Daudé [this message]
2022-03-04 20:20 ` Richard Henderson
2022-03-04 11:21 ` [PATCH v2 7/9] util: Use meson checks for valloc() and memalign() presence Peter Maydell
2022-03-04 11:21 ` [PATCH v2 8/9] util: Put qemu_vfree() in memalign.c Peter Maydell
2022-03-04 14:03 ` Philippe Mathieu-Daudé
2022-03-04 11:21 ` [PATCH v2 9/9] osdep: Move memalign-related functions to their own header Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff763044-1e6a-18ea-02b9-9f7a7107bf43@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).