From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
den@openvz.org, jsnow@redhat.com
Subject: Re: [PATCH v6 08/11] iotests: add testenv.py
Date: Mon, 18 Jan 2021 20:00:25 +0300 [thread overview]
Message-ID: <ff7e7cce-36b3-074c-7cc9-43d7d2d3439e@virtuozzo.com> (raw)
In-Reply-To: <20210118095939.GA11555@merkur.fritz.box>
18.01.2021 12:59, Kevin Wolf wrote:
> Am 16.01.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> 15.01.2021 16:30, Vladimir Sementsov-Ogievskiy wrote:
>>> 15.01.2021 16:20, Kevin Wolf wrote:
>>>> Am 15.01.2021 um 14:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>>>> 15.01.2021 15:45, Kevin Wolf wrote:
>>>>>> Am 15.01.2021 um 13:19 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>>>>>> 15.01.2021 14:18, Kevin Wolf wrote:
>>>>>>>> Am 09.01.2021 um 13:26 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>>>>>>>> Add TestEnv class, which will handle test environment in a new python
>>>>>>>>> iotests running framework.
>>>>>>>>>
>>>>>>>>> Difference with current ./check interface:
>>>>>>>>> - -v (verbose) option dropped, as it is unused
>>>>>>>>>
>>>>>>>>> - -xdiff option is dropped, until somebody complains that it is needed
>>>>>>>>> - same for -n option
>>>>>>>>>
>>>>>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>>>>>>> ---
>>>>>>>>> Â Â Â tests/qemu-iotests/testenv.py | 328 ++++++++++++++++++++++++++++++++++
>>>>>>>>> Â Â Â 1 file changed, 328 insertions(+)
>>>>>>>>> Â Â Â create mode 100755 tests/qemu-iotests/testenv.py
>>>>>>>>>
>>>>>
>>>>> [..]
>>>>>
>>>>>>>>> +Â Â Â def init_binaries(self):
>>>>>>>>> +Â Â Â Â Â Â Â """Init binary path variables:
>>>>>>>>> +Â Â Â Â Â Â Â Â Â Â Â Â PYTHON (for bash tests)
>>>>>>>>> +Â Â Â Â Â Â Â Â Â Â Â Â QEMU_PROG, QEMU_IMG_PROG, QEMU_IO_PROG, QEMU_NBD_PROG, QSD_PROG
>>>>>>>>> +Â Â Â Â Â Â Â Â Â Â Â Â SOCKET_SCM_HELPER
>>>>>>>>> +Â Â Â Â Â Â Â """
>>>>>>>>> +Â Â Â Â Â Â Â self.python = '/usr/bin/python3 -B'
>>>>>>>>
>>>>>>>> This doesn't look right, we need to respect the Python binary set in
>>>>>>>> configure (which I think we get from common.env)
>>>>>>>
>>>>>>> Oh, I missed the change. Then I should just drop this self.python.
>>>>>>
>>>>>> Do we still get the value from elsewhere or do we need to manually parse
>>>>>> common.env?
>>>>>
>>>>> Hmm.. Good question. We have either parse common.env, and still create self.python variable.
>>>>>
>>>>> Or drop it, and include common.env directly to bash tests. For this we'll need to export
>>>>>
>>>>> BUILD_IOTESTS, and do
>>>>> Â . $BUILD_IOTESTS/common.env
>>>>>
>>>>> in common.rc..
>>>>
>>>> check uses it, too, for running Python test cases.
>>>>
>>>
>>> But new check (written in python) doesn't.. Should I keep bash check, which will have only one line to call check.py with help of PYTHON?
>>>
>>>
>>
>> Or finally, may be just drop it? Can we just use system python for
>> tests, now when we are already in a python3 world?
>
> You can only assume the Python 3 (or more specifically 3.6+) world if
> you are using the Python interpreter that was passed to configure. This
> will commonly be the same thing as the first python3 in PATH, but it
> doesn't have to be.
>
> So your solution of just using the same interpreter as for check might
> be okay as long as we make sure that 'make check' calls check with the
> configured Python interpreter instead of relying on the shebang line.
>
I've sent v7 with exactly this thing: use same interpreter as for check and adjust check-block.sh which is called from make check
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-01-18 17:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 12:26 [PATCH v6 00/11] Rework iotests/check Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.py running Vladimir Sementsov-Ogievskiy
2021-01-13 22:37 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running Vladimir Sementsov-Ogievskiy
2021-01-13 22:38 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 03/11] iotests: fix some whitespaces in test output files Vladimir Sementsov-Ogievskiy
2021-01-13 22:51 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 04/11] iotests: make tests executable Vladimir Sementsov-Ogievskiy
2021-01-13 22:53 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 05/11] iotests/294: add shebang line Vladimir Sementsov-Ogievskiy
2021-01-13 22:54 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 06/11] iotests: define group in each iotest Vladimir Sementsov-Ogievskiy
2021-01-13 23:01 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 07/11] iotests: add findtests.py Vladimir Sementsov-Ogievskiy
2021-01-12 16:42 ` Kevin Wolf
2021-01-13 10:37 ` Vladimir Sementsov-Ogievskiy
2021-01-13 11:18 ` Kevin Wolf
2021-01-14 7:38 ` Vladimir Sementsov-Ogievskiy
2021-01-14 10:48 ` Kevin Wolf
2021-01-13 23:10 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 08/11] iotests: add testenv.py Vladimir Sementsov-Ogievskiy
2021-01-12 17:36 ` Kevin Wolf
2021-01-14 6:14 ` Vladimir Sementsov-Ogievskiy
2021-01-14 6:16 ` Vladimir Sementsov-Ogievskiy
2021-01-14 4:28 ` Vladimir Sementsov-Ogievskiy
2021-01-14 11:14 ` Kevin Wolf
2021-01-14 11:26 ` Vladimir Sementsov-Ogievskiy
2021-01-15 11:18 ` Kevin Wolf
2021-01-15 12:19 ` Vladimir Sementsov-Ogievskiy
2021-01-15 12:45 ` Kevin Wolf
2021-01-15 13:10 ` Vladimir Sementsov-Ogievskiy
2021-01-15 13:20 ` Kevin Wolf
2021-01-15 13:30 ` Vladimir Sementsov-Ogievskiy
2021-01-16 11:03 ` Vladimir Sementsov-Ogievskiy
2021-01-16 11:19 ` Vladimir Sementsov-Ogievskiy
2021-01-18 9:59 ` Kevin Wolf
2021-01-18 17:00 ` Vladimir Sementsov-Ogievskiy [this message]
2021-01-09 12:26 ` [PATCH v6 09/11] iotests: add testrunner.py Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 10/11] iotests: rewrite check into python Vladimir Sementsov-Ogievskiy
2021-01-12 17:41 ` Kevin Wolf
2021-01-13 23:20 ` Eric Blake
2021-01-14 0:18 ` John Snow
2021-01-09 12:26 ` [PATCH v6 11/11] iotests: rename and move 169 and 199 tests Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff7e7cce-36b3-074c-7cc9-43d7d2d3439e@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).