From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnvBO-0007xP-VS for qemu-devel@nongnu.org; Fri, 01 Sep 2017 19:17:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnvBN-00064Q-VZ for qemu-devel@nongnu.org; Fri, 01 Sep 2017 19:17:02 -0400 References: <20170901180340.30009-1-eblake@redhat.com> <20170901180340.30009-29-eblake@redhat.com> From: John Snow Message-ID: Date: Fri, 1 Sep 2017 19:16:47 -0400 MIME-Version: 1.0 In-Reply-To: <20170901180340.30009-29-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 28/29] libqtest: Remove qtest_start() and qtest_end() shortcuts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Thomas Huth , "open list:Floppy" , Ben Warren , "Michael S. Tsirkin" , Jason Wang , Amit Shah , armbru@redhat.com, Alexander Graf , Keith Busch , "open list:sPAPR" , Gerd Hoffmann , Stefan Hajnoczi , pbonzini@redhat.com, =?UTF-8?Q?Andreas_F=c3=a4rber?= , "Dr. David Alan Gilbert" , David Gibson On 09/01/2017 02:03 PM, Eric Blake wrote: > Remove the trivial wrappers qtest_start() and qtest_end(), to make > it obvious in the rest of the testsuite where we are still relying on > global_qtest. Doing this makes it easier to see what remaining > cleanups will be needed if we don't want an implicit dependency > on global state. Many tests can also take advantage of qtest_init() > doing formatting of args, avoiding a temporary local variable. > > Signed-off-by: Eric Blake Reviewed-by: John Snow diffstat looks like a win overall, unless it's just a local minima ;)