qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Sean Wei <me@sean.taipei>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, Jason Wang <jasowang@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Dr . David Alan Gilbert" <dave@treblig.org>
Subject: Re: [PATCH 2/6] MAINTAINERS: fix paths for relocated files
Date: Tue, 1 Jul 2025 19:24:08 +0200	[thread overview]
Message-ID: <ff8a559e-f1d7-45a8-a292-20c9ab697646@redhat.com> (raw)
In-Reply-To: <20250616.qemu.relocated.02@sean.taipei>

On 16/06/2025 17.48, Sean Wei wrote:
> Several files were renamed in previous commits, causing their entries
> in MAINTAINERS to reference outdated paths.
> This prevents scripts/get_maintainer.pl from correctly matching
> these files to their maintainers.
> 
> Update the filenames to reflect their current locations so that
> maintainer lookup works properly.
> 
> Related commits
> ---------------
> 
>    c45460decbd (Oct 2023)
>      hw/input/stellaris_input: Rename to stellaris_gamepad
>      Rename  include/hw/input/{gamepad.h => stellaris_gamepad.h}
> 
>    4faf359accb (Nov 2020)
>      docs: Move virtio-net-failover.rst into the system manual
>      Rename  docs/{ => system}/virtio-net-failover.rst
> 
>    89857312f32 (Apr 2024)
>      hw/usb: move stubs out of stubs/
>      Rename  stubs/usb-dev-stub.c => hw/usb/bus-stub.c
> 
>    f2604d8508a (Apr 2024)
>      hw/virtio: move stubs out of stubs/
>      Rename  stubs/virtio-md-pci.c => hw/virtio/virtio-md-stubs.c
> 
>    2c888febdfa (Apr 2024)
>      memory-device: move stubs out of stubs/
>      Rename  stubs/memory_device.c => hw/mem/memory-device-stubs.c
> 
>    d481cec7565 (Oct 2024)
>      migration: Move cpu-throttle.c from system to migration
>      Rename  {system => migration}/cpu-throttle.c
> 
>    864a3fa4392 (Jan 2023)
>      monitor: Rename misc.c to hmp-target.c
>      Rename  monitor/{misc.c => hmp-target.c}
> 
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
>   MAINTAINERS | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fed8619874..0477e124d1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1002,7 +1002,7 @@ L: qemu-arm@nongnu.org
>   S: Odd Fixes
>   F: hw/*/stellaris*
>   F: hw/display/ssd03*
> -F: include/hw/input/gamepad.h
> +F: include/hw/input/stellaris_gamepad.h
>   F: include/hw/timer/stellaris-gptm.h
>   F: docs/system/arm/stellaris.rst
>   F: tests/functional/test_arm_stellaris.py
> @@ -2163,7 +2163,7 @@ F: hw/net/
>   F: include/hw/net/
>   F: tests/qtest/virtio-net-test.c
>   F: tests/functional/test_info_usernet.py
> -F: docs/virtio-net-failover.rst
> +F: docs/system/virtio-net-failover.rst
>   T: git https://github.com/jasowang/qemu.git net
>   
>   Parallel NOR Flash devices
> @@ -2214,7 +2214,7 @@ F: tests/qtest/sdhci-test.c
>   USB
>   S: Orphan
>   F: hw/usb/*
> -F: stubs/usb-dev-stub.c
> +F: hw/usb/bus-stub.c

I think we could simply drop this line now completely since it is already 
covered by the previous hw/usb/* wildcard line.

>   F: tests/qtest/usb-*-test.c
>   F: docs/system/devices/usb.rst
>   F: include/hw/usb.h
> @@ -2469,7 +2469,7 @@ F: hw/s390x/virtio-ccw-md.h
>   F: hw/s390x/virtio-ccw-md-stubs.c
>   F: hw/virtio/virtio-md-pci.c
>   F: include/hw/virtio/virtio-md-pci.h
> -F: stubs/virtio-md-pci.c
> +F: hw/virtio/virtio-md-stubs.c

Could be merged with the hw/virtio/virtio-md-pci.c line by turning it into:

F: hw/virtio/virtio-md-*.c

>   virtio-mem
>   M: David Hildenbrand <david@redhat.com>
> @@ -3187,7 +3187,7 @@ F: hw/mem/pc-dimm.c
>   F: include/hw/mem/memory-device.h
>   F: include/hw/mem/nvdimm.h
>   F: include/hw/mem/pc-dimm.h
> -F: stubs/memory_device.c
> +F: hw/mem/memory-device-stubs.c

This could be merged with the preceeding "hw/mem/memory-device.c" line, too, 
by turning it into:

F: hw/mem/memory-device*.c

  Thomas



  reply	other threads:[~2025-07-01 17:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 15:46 [PATCH 0/6] Fix paths for relocated files Sean Wei
2025-06-16 15:47 ` [PATCH 1/6] MAINTAINERS: update docs file extensions (.txt -> .rst) Sean Wei
2025-07-01 17:18   ` Thomas Huth
2025-06-16 15:48 ` [PATCH 2/6] MAINTAINERS: fix paths for relocated files Sean Wei
2025-07-01 17:24   ` Thomas Huth [this message]
2025-07-01 18:06     ` Sean Wei
2025-07-01 18:54       ` Thomas Huth
2025-06-16 15:49 ` [PATCH 3/6] MAINTAINERS: fix vendor capitalization (Vmware -> VMware) Sean Wei
2025-06-16 15:50 ` [PATCH 4/6] MAINTAINERS: fix VMware filename typo (vwm -> vmw) Sean Wei
2025-07-01 17:25   ` Thomas Huth
2025-06-16 15:50 ` [PATCH 5/6] treewide: update docs file extensions (.txt -> .rst) in comments Sean Wei
2025-07-01 17:28   ` Thomas Huth
2025-07-02  5:50   ` Harsh Prateek Bora
2025-06-16 15:51 ` [PATCH 6/6] treewide: fix paths for relocated files " Sean Wei
2025-07-01 17:32   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff8a559e-f1d7-45a8-a292-20c9ab697646@redhat.com \
    --to=thuth@redhat.com \
    --cc=dave@treblig.org \
    --cc=david@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=me@sean.taipei \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).