[PULL 0/1] Host Memory Backends and Memory devices queue 2024-07-10

[PULL 0/1] Host Memory Backends and Memory devices queue 2024-07-10

[David Hildenbrand]

The following changes since commit 59084feb256c617063e0dbe7e64821ae8852d7cf:

  Merge tag 'pull-aspeed-20240709' of https://github.com/legoater/qemu into staging (2024-07-09 07:13:55 -0700)

are available in the Git repository at:

  https://github.com/davidhildenbrand/qemu.git tags/mem-2024-07-10

for you to fetch changes up to 4d13ae45ff93fa825ceb39dfd16b305f4baccd18:

  virtio-mem: improve error message when unplug of device fails due to plugged memory (2024-07-10 18:06:24 +0200)

----------------------------------------------------------------
Hi,

"Host Memory Backends" and "Memory devices" queue ("mem"):
- Only one error message improvement that causes less confusion when
  triggered from libvirt

----------------------------------------------------------------
David Hildenbrand (1):
      virtio-mem: improve error message when unplug of device fails due to plugged memory

 hw/virtio/virtio-mem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.45.2

[PULL 1/1] virtio-mem: improve error message when unplug of device fails due to plugged memory

[David Hildenbrand]

The error message is actually expressive, considering QEMU only. But
when called from Libvirt, talking about "size" can be confusing, because
in Libvirt "size" translates to the memory backend size in QEMU (maximum
size) and "current" translates to the QEMU "size" property.

Let's simply avoid talking about the "size" property and spell out that
some device memory is still plugged.

Message-ID: <20240416141426.588544-1-david@redhat.com>
Tested-by: Mario Casquero <mcasquer@redhat.com>
Cc: Liang Cong <lcong@redhat.com>
Cc: Mario Casquero <mcasquer@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 hw/virtio/virtio-mem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
index ffd119ebac..ef64bf1b4a 100644
--- a/hw/virtio/virtio-mem.c
+++ b/hw/virtio/virtio-mem.c
@@ -1832,8 +1832,8 @@ static void virtio_mem_unplug_request_check(VirtIOMEM *vmem, Error **errp)
     }
 
     if (vmem->size) {
-        error_setg(errp, "virtio-mem device cannot get unplugged while"
-                   " '" VIRTIO_MEM_SIZE_PROP "' != '0'");
+        error_setg(errp, "virtio-mem device cannot get unplugged while some"
+                   " of its memory is still plugged");
         return;
     }
     if (vmem->requested_size) {
-- 
2.45.2

Re: [PULL 0/1] Host Memory Backends and Memory devices queue 2024-07-10

[Richard Henderson]

On 7/10/24 11:00, David Hildenbrand wrote:
> The following changes since commit 59084feb256c617063e0dbe7e64821ae8852d7cf:
> 
>    Merge tag 'pull-aspeed-20240709' ofhttps://github.com/legoater/qemu  into staging (2024-07-09 07:13:55 -0700)
> 
> are available in the Git repository at:
> 
>    https://github.com/davidhildenbrand/qemu.git  tags/mem-2024-07-10
> 
> for you to fetch changes up to 4d13ae45ff93fa825ceb39dfd16b305f4baccd18:
> 
>    virtio-mem: improve error message when unplug of device fails due to plugged memory (2024-07-10 18:06:24 +0200)
> 
> ----------------------------------------------------------------
> Hi,
> 
> "Host Memory Backends" and "Memory devices" queue ("mem"):
> - Only one error message improvement that causes less confusion when
>    triggered from libvirt

Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/9.1 as appropriate.

r~