From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] hw/core/cpu: Add missing 'exec/cpu-common.h' include
Date: Thu, 1 Oct 2020 19:44:57 +0200 [thread overview]
Message-ID: <ff99f676-2e6d-2f23-5a09-96cc77fb8469@redhat.com> (raw)
In-Reply-To: <20200908123433.105706-1-philmd@redhat.com>
ping?
On 9/8/20 2:34 PM, Philippe Mathieu-Daudé wrote:
> cpu_common_reset() uses tcg_flush_softmmu_tlb() which is
> declared in "exec/cpu-common.h". Add the missing header
> to avoid when refactoring other headers:
>
> hw/core/cpu.c: In function ‘cpu_common_reset’:
> hw/core/cpu.c:273:9: error: implicit declaration of function ‘tcg_flush_softmmu_tlb’ [-Werror=implicit-function-declaration]
> 273 | tcg_flush_softmmu_tlb(cpu);
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/core/cpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/core/cpu.c b/hw/core/cpu.c
> index 22bc3f974a2..63ece3662d6 100644
> --- a/hw/core/cpu.c
> +++ b/hw/core/cpu.c
> @@ -26,6 +26,7 @@
> #include "qemu/log.h"
> #include "qemu/main-loop.h"
> #include "exec/log.h"
> +#include "exec/cpu-common.h"
> #include "qemu/error-report.h"
> #include "qemu/qemu-print.h"
> #include "sysemu/tcg.h"
>
next prev parent reply other threads:[~2020-10-01 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 12:34 [PATCH] hw/core/cpu: Add missing 'exec/cpu-common.h' include Philippe Mathieu-Daudé
2020-10-01 17:44 ` Philippe Mathieu-Daudé [this message]
2020-10-01 17:56 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff99f676-2e6d-2f23-5a09-96cc77fb8469@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).