From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97B81C433E0 for ; Fri, 15 Jan 2021 18:41:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 397FD23A59 for ; Fri, 15 Jan 2021 18:41:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 397FD23A59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0U2F-0008Bi-AR for qemu-devel@archiver.kernel.org; Fri, 15 Jan 2021 13:41:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0U0K-00076a-I1 for qemu-devel@nongnu.org; Fri, 15 Jan 2021 13:39:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22285) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l0U0H-0003oS-7K for qemu-devel@nongnu.org; Fri, 15 Jan 2021 13:39:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610735959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fVQAxGhloJfXhsIdW2TkBSf1TW/KzxdmhCRAkemgs50=; b=OXRJqKMxEY+0RxNpuzT1vlquayeGwUpztDb3dSJUqrOeVaTqLFV7rUbkC0dgDS9bqus2tV 0Fau36pw+tfSAJ3C1e5kyf1pGCtvvf/j/TqkvusnRGlKg6C63pP8MkNJ7V5V+01bO40M1H v+uqAjN8F5kC6mlSfcTW0tORJLt+W+c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-dPo0I2pWN-ysVcZOTaEhZA-1; Fri, 15 Jan 2021 13:39:15 -0500 X-MC-Unique: dPo0I2pWN-ysVcZOTaEhZA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 94E3F107ACF8; Fri, 15 Jan 2021 18:39:14 +0000 (UTC) Received: from wainer-laptop.localdomain (ovpn-116-88.gru2.redhat.com [10.97.116.88]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB26B100239F; Fri, 15 Jan 2021 18:39:10 +0000 (UTC) Subject: Re: [PATCH v2 08/25] tests/docker: fix mistakes in centos package lists To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org References: <20210114130245.1654081-1-berrange@redhat.com> <20210114130245.1654081-9-berrange@redhat.com> From: Wainer dos Santos Moschetta Message-ID: Date: Fri, 15 Jan 2021 15:39:07 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210114130245.1654081-9-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/14/21 10:02 AM, Daniel P. Berrangé wrote: > dbus-daemon doesn't exist in centos7, it is part of dbus. > > snappy is used by QEMU, not csnappy. > > mesa-libEGL-devel is not used in QEMU at all, but mesa-libgbm-devel is. > > vte291-devel is required for GTK3, not vte-devel. > > spice-glib-devel is not use in QEMU at all, but spice-protocol is. > > librdmacm-devel is a virtual provides for compat, the actual package > used is rdma-core-devel. > > There is no need to specifically refer to python36, we can just > use python3 as in other distros. > > Signed-off-by: Daniel P. Berrangé > --- > tests/docker/dockerfiles/centos7.docker | 11 +++++------ > tests/docker/dockerfiles/centos8.docker | 10 +++++----- > 2 files changed, 10 insertions(+), 11 deletions(-) Reviewed-by: Wainer dos Santos Moschetta > > diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker > index b2a4719284..1eb3455144 100644 > --- a/tests/docker/dockerfiles/centos7.docker > +++ b/tests/docker/dockerfiles/centos7.docker > @@ -9,8 +9,7 @@ ENV PACKAGES \ > bzip2 \ > bzip2-devel \ > ccache \ > - csnappy-devel \ > - dbus-daemon \ > + dbus \ > gcc \ > gcc-c++ \ > gettext \ > @@ -22,21 +21,21 @@ ENV PACKAGES \ > libepoxy-devel \ > libfdt-devel \ > libgcrypt-devel \ > - librdmacm-devel \ > libzstd-devel \ > lzo-devel \ > make \ > - mesa-libEGL-devel \ > mesa-libgbm-devel \ > nettle-devel \ > ninja-build \ > perl-Test-Harness \ > pixman-devel \ > python3 \ > - spice-glib-devel \ > + rdma-core-devel \ > + snappy-devel \ > + spice-protocol \ > spice-server-devel \ > tar \ > - vte-devel \ > + vte291-devel \ > xen-devel \ > zlib-devel > RUN yum install -y $PACKAGES > diff --git a/tests/docker/dockerfiles/centos8.docker b/tests/docker/dockerfiles/centos8.docker > index a95350466a..b64ee7071d 100644 > --- a/tests/docker/dockerfiles/centos8.docker > +++ b/tests/docker/dockerfiles/centos8.docker > @@ -19,16 +19,16 @@ ENV PACKAGES \ > libgcrypt-devel \ > lzo-devel \ > make \ > - mesa-libEGL-devel \ > - nmap-ncat \ > + mesa-libgbm-devel \ > nettle-devel \ > ninja-build \ > + nmap-ncat \ > perl-Test-Harness \ > pixman-devel \ > - python36 \ > + python3 \ > rdma-core-devel \ > - spice-glib-devel \ > - spice-server \ > + spice-protocol \ > + spice-server-devel \ > tar \ > zlib-devel >