From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8AD3CCF9EE for ; Wed, 29 Oct 2025 13:49:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vE6Y1-0007mE-Ai; Wed, 29 Oct 2025 09:49:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vE6XV-0007eV-OC for qemu-devel@nongnu.org; Wed, 29 Oct 2025 09:48:44 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vE6XJ-0003Zr-5i for qemu-devel@nongnu.org; Wed, 29 Oct 2025 09:48:33 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-47114a40161so82079665e9.3 for ; Wed, 29 Oct 2025 06:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761745697; x=1762350497; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c1qQvbqi4yBxcPcwn4iVcr8K3QLP8jEh1kZNbm4KrPQ=; b=Nifd+fhdhxIqnyfYDT3hCwwT1tkekHjaG+74xjVk6L9KVQApQ8p8mnWYlwLeeT1BMM MBixYTCc3SpOnoI4H4Dn5GZkiUPfpSVXhVxfRa/gjzyJJU7ATUoIebu+ZJSi1uNyZSqj L1nsu9o1ryTt8Z28/MJZ+qiAXtfw82fMNrFRoFEy/1NqdQOYfuthX7xZlIDrhJTsoObc 45cF2p3CuD5HBK2efrNTKNDEWxQq6zdaCPGVzuTsg7zXOsJ12FAaFwSOoF2PhnEQXpSk u4UOr7XB7XW0ol3A4prYyE7OoU+dxAKBQaGKrms7X95V/DBWmIwy0WZXNrUdPyYc/Yyz 13Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761745697; x=1762350497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c1qQvbqi4yBxcPcwn4iVcr8K3QLP8jEh1kZNbm4KrPQ=; b=BvyQteQtrEwFaNtzFOBedeiPuYK36ftUSjpn5DaoNGHJo7s+sbC2fVKfkzeFVzaPxl udql79mTOVZSUBsRTYpz/zJlqF/K67jbrJ85vOYnmX6Hza3f4538eb64TLPp3/8/EqMJ F8MDzSMg86B1HrREMWZ37gGLC4+QJFR1XIEN3opqwPj0F3LNLKMESGQZt5Gdk3dP7Gru qmKwZ+IuZQWmlvV6JIYKQKkb9NoVy4VKpnzCFpoEYSODaInTbhY2X5lWfq665jT+Sg83 6rVjZZVUNe6wktWzTaKTaoqUTG81BnH1uClTpT8joEbcybELTuq5JINm6STb5fg3W5eV 5i4Q== X-Forwarded-Encrypted: i=1; AJvYcCUrqpoYF07MtCznoF9CLi5e0WiO96fUUwCVgjgOpaHJAqQCZW5W8rlqwouHveNRX/SUzux+Lxzj4YQo@nongnu.org X-Gm-Message-State: AOJu0Yx2jBdzdaJyzCOA/JJgpJV/rD1jSLeJX1n4tLUbz+hsMUluCYdo g5W3c/1mwC8QhYPPMnlLApUp/87Weu3vvWlS+tFuPzYBe/JeDoFWnlep5pdqqRwfqrw= X-Gm-Gg: ASbGncv2ii/FJYK4lFUrS3nrU0q7IwujgchZCGkDq9G0clQrfKckncHE9j8pfcnNnRp f4vp/x3rQdB+0XDzsyb5rYjhvnFFJLvvFq7ylbqUXn/60RvOY0zUZaLOdVJiJ50f0Dd01SADDvP 9ZBF6mJGfF6XzjJ5nsmCazTxIAzJjKzrSQ3tmSrEKG2ZQCjL11CbMEVBkOLi31smwLDUlumfks/ tlJICoiH+xVUixJlnifJDrt2vaRsfjvh5kpU/a6dDWkvhkd9y8YshP7f/JmNUAxTO12VPR7qWCG r6GQ63xg3hoN3jAyG0eieUBDHROPTVWvJG1ZDE2BiQ0YpW5bt4QYjlnokwOdLxQNSWVJfIHIgVu NQ8iw8eMJE4PWRskzmCZovTLO4/wPWzFpuMvDsHERqqYS0sDzZcMaGlAwfXrpxhJIRmVJ6XtTI0 Dfm4M2Yc1WqlnUJUbur6s7s4P6O77FLJYGarv1Sl1R+s3h9KeZnXWjFA== X-Google-Smtp-Source: AGHT+IHbgr0INbXg6avQXJ3yz2hy02sD0qNDWaG3WATmfNqpeCTn4IE1Ha92zFGz3/IV2Xd7qcbGEQ== X-Received: by 2002:a05:600c:6207:b0:45d:f83b:96aa with SMTP id 5b1f17b1804b1-477208d1be0mr21824675e9.7.1761745697226; Wed, 29 Oct 2025 06:48:17 -0700 (PDT) Received: from [192.168.69.201] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952b7b6fsm26617361f8f.1.2025.10.29.06.48.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Oct 2025 06:48:16 -0700 (PDT) Message-ID: Date: Wed, 29 Oct 2025 14:48:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 19/35] audio: register and unregister vmstate with AudioState Content-Language: en-US To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: Alexandre Ratchov , =?UTF-8?Q?Alex_Benn=C3=A9e?= , Jan Kiszka , "Michael S. Tsirkin" , Marcel Apfelbaum , Yanan Wang , Thomas Huth , Gerd Hoffmann , Peter Maydell , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , Manos Pitsidianakis , qemu-ppc@nongnu.org, Jiaxun Yang , Akihiko Odaki , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , qemu-arm@nongnu.org, Alistair Francis , Zhao Liu , =?UTF-8?Q?Volker_R=C3=BCmelin?= , Christian Schoenebeck , Paolo Bonzini , "Edgar E. Iglesias" , BALATON Zoltan , Laurent Vivier References: <20251027151045.2863176-1-marcandre.lureau@redhat.com> <20251027151045.2863176-20-marcandre.lureau@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20251027151045.2863176-20-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 27/10/25 16:10, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Proper lifecycle management with QOM state. > > Signed-off-by: Marc-André Lureau > --- > audio/audio.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/audio/audio.c b/audio/audio.c > index 4c3c3fd52f..853930bb48 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -1614,6 +1614,8 @@ static void audio_vm_change_state_handler (void *opaque, bool running, > audio_reset_timer (s); > } > > +static const VMStateDescription vmstate_audio; > + > static void audio_state_init(Object *obj) > { > AudioState *s = AUDIO_STATE(obj); > @@ -1625,6 +1627,8 @@ static void audio_state_init(Object *obj) > > s->vmse = qemu_add_vm_change_state_handler(audio_vm_change_state_handler, s); > assert(s->vmse != NULL); > + > + vmstate_register_any(NULL, &vmstate_audio, s); Please avoid legacy APIs: /** * vmstate_register_any() - legacy function to register state * serialisation description and let the function choose the id * * New code shouldn't be using this function as QOM-ified devices have * dc->vmsd to store the serialisation description. * * Returns: 0 on success, -1 on failure */