From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH-for-9.2? v2 1/2] hw/display/vga: Do not reset 'big_endian_fb' in vga_common_reset()
Date: Fri, 06 Dec 2024 10:00:37 +1100 [thread overview]
Message-ID: <ffac691bd93fee5192b8e91b03171422e5df0a1b.camel@kernel.crashing.org> (raw)
In-Reply-To: <yqxiqgaazxuvvtx3onfqlndx2t2sa3i7iykufkl56r45iwyusj@xatjov5qiea2>
On Tue, 2024-12-03 at 11:51 +0100, Gerd Hoffmann wrote:
>
> The only case I'm aware of where the byte order is actually switched is
> booting a ppc64le guest in a pseries machine, where the opal firmware
> runs in bigendian mode and the linux kernel runs in little endian mode.
>
> So here the changed reset behavior could actually make a difference, but
> you will only notice if the opal firmware does *not* set the byte order
> register.
OPAL (well skiboot) doesn't display anything anyways (or at least it
didn't when I wrote it :-). It just boots Linux as a bootloader. So as
long as Linux itself sets the register it should be fine.
Cheers,
Ben.
next prev parent reply other threads:[~2024-12-05 23:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 10:17 [PATCH v2 0/2] hw/display/vga: Do not reset 'big_endian_fb' in vga_common_reset() Philippe Mathieu-Daudé
2024-11-29 10:17 ` [PATCH-for-9.2? v2 1/2] " Philippe Mathieu-Daudé
2024-12-02 19:48 ` Philippe Mathieu-Daudé
2024-12-03 1:30 ` Benjamin Herrenschmidt
2024-12-03 10:51 ` Gerd Hoffmann
2024-12-03 12:21 ` BALATON Zoltan
2024-12-05 23:00 ` Benjamin Herrenschmidt [this message]
2024-12-06 9:28 ` Gerd Hoffmann
2024-12-09 1:12 ` Benjamin Herrenschmidt
2024-11-29 10:17 ` [PATCH v2 2/2] hw/display/vga: Remove pointless VGACommonState::default_endian_fb Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffac691bd93fee5192b8e91b03171422e5df0a1b.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).