From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, qemu-devel@nongnu.org,
mreitz@redhat.com, stefanha@redhat.com, den@openvz.org
Subject: Re: [PATCH v2 2/6] block/nbd-client: drop max_block restriction from discard
Date: Mon, 4 May 2020 14:59:05 -0500 [thread overview]
Message-ID: <ffae80d5-0302-f719-8934-21bb4a7eacca@redhat.com> (raw)
In-Reply-To: <e3253b06-4bff-970d-9b9b-32da6bf652b8@redhat.com>
On 4/21/20 4:56 PM, Eric Blake wrote:
> On 4/1/20 10:01 AM, Vladimir Sementsov-Ogievskiy wrote:
>> NBD spec is updated, so that max_block doesn't relate to
>> NBD_CMD_TRIM. So, drop the restriction.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>> block/nbd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> I might tweak the commit message of 1/6 and here to call out the NBD
> spec commit id (nbd.git 9f30fedb), but that doesn't change the patch
> proper.
I'm queuing 1 and 2 through my NBD tree now; the rest involve more of
the block layer and go in tandem with your other work on cleaning up
64-bit operations throughout, and I still need to give that a better review.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-04 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 15:01 [PATCH v2 0/6] nbd: reduce max_block restrictions Vladimir Sementsov-Ogievskiy
2020-04-01 15:01 ` [PATCH v2 1/6] block/nbd-client: drop max_block restriction from block_status Vladimir Sementsov-Ogievskiy
2020-04-01 15:01 ` [PATCH v2 2/6] block/nbd-client: drop max_block restriction from discard Vladimir Sementsov-Ogievskiy
2020-04-21 21:56 ` Eric Blake
2020-05-04 19:59 ` Eric Blake [this message]
2020-05-06 6:08 ` Vladimir Sementsov-Ogievskiy
2020-04-01 15:01 ` [PATCH v2 3/6] block: add max_pwrite_zeroes_fast to BlockLimits Vladimir Sementsov-Ogievskiy
2020-04-01 15:01 ` [PATCH v2 4/6] block/nbd: define new max_write_zero_fast limit Vladimir Sementsov-Ogievskiy
2020-04-01 15:01 ` [PATCH v2 5/6] block/io: refactor bdrv_co_do_pwrite_zeroes head calculation Vladimir Sementsov-Ogievskiy
2020-04-01 15:01 ` [PATCH v2 6/6] block/io: auto-no-fallback for write-zeroes Vladimir Sementsov-Ogievskiy
2020-04-01 16:52 ` [PATCH v2 0/6] nbd: reduce max_block restrictions no-reply
2020-04-03 5:12 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffae80d5-0302-f719-8934-21bb4a7eacca@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).