qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mihail Abakumov <mikhail.abakumov@ispras.ru>
To: Qemu Devel <qemu-devel@nongnu.org>
Cc: Pavel Dovgalyuk <dovgaluk@ispras.ru>,
	Pbonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PATCH] i386: fix read/write cr with icount option
Date: Fri, 19 May 2017 12:36:15 +0300	[thread overview]
Message-ID: <ffb376034ff184f2fcbe93d5317d9e76@ispras.ru> (raw)

Running Windows with icount causes a crash in instruction of write cr. 
This patch fixes it.

Reading and writing cr cause an icount read because there are called 
cpu_get_apic_tpr and cpu_set_apic_tpr functions. So, there is need 
gen_io_start()/gen_io_end() calls.

---
  target/i386/translate.c | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/target/i386/translate.c b/target/i386/translate.c
index 06d8833..3b009bd 100644
--- a/target/i386/translate.c
+++ b/target/i386/translate.c
@@ -7907,14 +7907,26 @@ static target_ulong disas_insn(CPUX86State *env, 
DisasContext *s,
                  gen_update_cc_op(s);
                  gen_jmp_im(pc_start - s->cs_base);
                  if (b & 2) {
+                    if (s->tb->cflags & CF_USE_ICOUNT) {
+                        gen_io_start();
+                    }
                      gen_op_mov_v_reg(ot, cpu_T0, rm);
                      gen_helper_write_crN(cpu_env, tcg_const_i32(reg),
                                           cpu_T0);
+                    if (s->tb->cflags & CF_USE_ICOUNT) {
+                        gen_io_end();
+                    }
                      gen_jmp_im(s->pc - s->cs_base);
                      gen_eob(s);
                  } else {
+                    if (s->tb->cflags & CF_USE_ICOUNT) {
+                        gen_io_start();
+                    }
                      gen_helper_read_crN(cpu_T0, cpu_env, 
tcg_const_i32(reg));
                      gen_op_mov_reg_v(ot, rm, cpu_T0);
+                    if (s->tb->cflags & CF_USE_ICOUNT) {
+                        gen_io_end();
+                    }
                  }
                  break;
              default:
-- 
1.9.1

             reply	other threads:[~2017-05-19  9:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19  9:36 Mihail Abakumov [this message]
2017-05-19  9:59 ` [Qemu-devel] [PATCH] i386: fix read/write cr with icount option Paolo Bonzini
2017-05-19 10:41   ` Mihail Abakumov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffb376034ff184f2fcbe93d5317d9e76@ispras.ru \
    --to=mikhail.abakumov@ispras.ru \
    --cc=dovgaluk@ispras.ru \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).