From: John Snow <jsnow@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Ashijeet Acharya <ashijeetacharya@gmail.com>,
kwolf@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org, stefanha@gmail.com
Subject: Re: [Qemu-devel] [PATCH v9 0/8] Optimize VMDK I/O by allocating multiple clusters
Date: Fri, 3 Nov 2017 13:08:30 -0400 [thread overview]
Message-ID: <ffb992c5-9bf5-f33e-c97b-304e23d13401@redhat.com> (raw)
In-Reply-To: <20171103035003.GA18539@lemon>
On 11/02/2017 11:50 PM, Fam Zheng wrote:
> On Thu, 11/02 17:02, John Snow wrote:
>>
>>
>> On 10/20/2017 02:53 AM, Ashijeet Acharya wrote:
>>>
>>> On Fri, Oct 20, 2017 at 11:58 Fam Zheng <famz@redhat.com
>>> <mailto:famz@redhat.com>> wrote:
>>>
>>> On Mon, 10/09 22:12, Fam Zheng wrote:
>>> > On Mon, 10/09 18:29, Ashijeet Acharya wrote:
>>> > > Optimization test results:
>>> > >
>>> > > This patch series improves 128 KB sequential write performance to an
>>> > > empty VMDK file by 54%
>>> > >
>>> > > Benchmark command: ./qemu-img bench -w -c 1024 -s 128K -d 1 -t
>>> none -f
>>> > > vmdk test.vmdk
>>> > >
>>> > > Changes in v9:
>>> > > - rebase the series
>>> >
>>> > Thanks, looks good to me, applied:
>>> >
>>> > https://github.com/famz/qemu/tree/staging
>>>
>>> Ashijeet: I've been testing my branch and it seems installing
>>> Fedora/CentOS to a
>>> VMDK image is broken with your patches applied. Both guest and QEMU are
>>> responsive, but the installing of packages stops to make any
>>> progress at some
>>> point:
>>>
>>> Installing rootfiles.noarch (317/318)
>>> Installing langpacks-en.noarch (318/318)
>>> Performing post-installation setup tasks
>>> Configuring fedora-release.noarch
>>> Configuring filesystem.x86_64
>>> Configuring GeoIP-GeoLite-data.noarch
>>> Configuring python3.x86_64
>>> Configuring fedora-logos.x86_64
>>> Configuring kernel-core.x86_64
>>>
>>> # hang here
>>>
>>> Can you reproduce this on your machine?
>>>
>>> My command line is something like this:
>>>
>>> qemu-system-x86_64 -enable-kvm -cpu host -m 1G -qmp
>>> unix:/home/fam/.q/qemu-8DOC9EF4/qmp,server,nowait -name 8DOC9EF4
>>> -netdev user,id=vnet,hostfwd=:0.0.0.0 <http://0.0.0.0>:10022-:22
>>> -device virtio-net-pci,netdev=vnet -drive
>>> file=/var/tmp/test2.vmdk,if=none,id=drive-1,cache=none,aio=native
>>> -device virtio-blk-pci,drive=drive-1 -cdrom
>>> /stor/iso/CentOS-6.9-x86_64-minimal.iso -pidfile
>>> /home/fam/.q/qemu-8DOC9EF4/pid
>>>
>>> qemu.git master doesn't have this problem. So I'll drop this series
>>> from the
>>> pull request until it is resolved.
>>>
>>>
>>> Fam: Alright, I will look into this but I cannot give you a deadline
>>> unfortunately. I will try my best to resolve this as soon as though.
>>>
>>> Ashijeet
>>>
>>>
>>>
>>> Fam
>>>
>>
>> Do we need to temporarily roll this back for the 2.11 release if it
>> cannot be addressed in time?
>
> Hi John, it's not merged yet, I dropped it from my pull request.
>
> Fam
>
OK thanks, just trying to get back up to speed and making sure things
that found their way into my "pay attention to this" folder are taken
care of.
:)
--js
prev parent reply other threads:[~2017-11-03 17:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 12:59 [Qemu-devel] [PATCH v9 0/8] Optimize VMDK I/O by allocating multiple clusters Ashijeet Acharya
2017-10-09 12:59 ` [Qemu-devel] [PATCH v9 1/8] vmdk: Move vmdk_find_offset_in_cluster() to the top Ashijeet Acharya
2017-10-09 12:59 ` [Qemu-devel] [PATCH v9 2/8] vmdk: Rename get_whole_cluster() to vmdk_perform_cow() Ashijeet Acharya
2017-10-09 12:59 ` [Qemu-devel] [PATCH v9 3/8] vmdk: Rename get_cluster_offset() to vmdk_get_cluster_offset() Ashijeet Acharya
2017-10-09 12:59 ` [Qemu-devel] [PATCH v9 4/8] vmdk: Factor out metadata loading code out of vmdk_get_cluster_offset() Ashijeet Acharya
2017-10-09 12:59 ` [Qemu-devel] [PATCH v9 5/8] vmdk: Set maximum bytes allocated in one cycle Ashijeet Acharya
2017-10-09 12:59 ` [Qemu-devel] [PATCH v9 6/8] vmdk: New functions to assist allocating multiple clusters Ashijeet Acharya
2017-10-09 12:59 ` [Qemu-devel] [PATCH v9 7/8] vmdk: Update metadata for " Ashijeet Acharya
2017-10-09 12:59 ` [Qemu-devel] [PATCH v9 8/8] vmdk: Make vmdk_get_cluster_offset() return cluster offset only Ashijeet Acharya
2017-10-09 14:12 ` [Qemu-devel] [PATCH v9 0/8] Optimize VMDK I/O by allocating multiple clusters Fam Zheng
2017-10-20 6:27 ` Fam Zheng
2017-10-20 6:53 ` Ashijeet Acharya
2017-11-02 21:02 ` John Snow
2017-11-03 3:50 ` Fam Zheng
2017-11-03 17:08 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffb992c5-9bf5-f33e-c97b-304e23d13401@redhat.com \
--to=jsnow@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).