From: Gavin Shan <gshan@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Marc Zyngier" <maz@kernel.org>, qemu-arm <qemu-arm@nongnu.org>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Shan Gavin" <shan.gavin@gmail.com>
Subject: Re: [PATCH] hw/char/pl011: Output characters using best-effort mode
Date: Mon, 24 Feb 2020 10:45:26 +1100 [thread overview]
Message-ID: <ffbb0513-e24c-d41b-d511-a4bd2340d90a@redhat.com> (raw)
In-Reply-To: <1ae86c0b-d4ab-8063-747b-ebea4950e76d@redhat.com>
On 2/22/20 5:15 AM, Paolo Bonzini wrote:
> On 21/02/20 14:14, Peter Maydell wrote:
>> The initial case reported by Gavin in this thread is
>> "-serial tcp:127.0.0.1:50900" with the other end being a program which
>> listens on TCP port 50900 and then sleeps without accepting any incoming
>> connections, which blocks the serial port output and effectively blocks
>> the guest bootup. If you want to insulate the guest from badly
>> behaved consumers like that (or the related consumer who accepts
>> the connection and then just doesn't read data from it) you probably
>> need to deal with more than just POLLHUP. But I'm not sure how much
>> we should care about these cases as opposed to just telling users
>> not to do that...
>
> No, I think we don't do anything (on purpose; that is, it was considered
> the lesser evil) for x86 in that case.
>
Paolo and Peter, thanks for your time on the discussion. So I think the
conclusion is we don't do anything for pl011 either? :)
Actually, the issue was reported by libvirt developer. A VM is started
with serial on tcp socket, which is never accepted on server side. It
practically blocks the VM to boot up. I will tell the libvirt developer
to hack their code to avoid the race if we don't do anything in qemu.
Thanks,
Gavin
next prev parent reply other threads:[~2020-02-23 23:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 6:01 [PATCH] hw/char/pl011: Output characters using best-effort mode Gavin Shan
2020-02-20 8:47 ` Philippe Mathieu-Daudé
2020-02-20 9:07 ` Gavin Shan
2020-02-20 9:10 ` Marc Zyngier
2020-02-20 10:10 ` Peter Maydell
2020-02-21 4:24 ` Gavin Shan
2020-02-21 9:09 ` Marc Zyngier
2020-02-23 23:57 ` Gavin Shan
2020-02-21 10:21 ` Peter Maydell
2020-02-21 11:44 ` Paolo Bonzini
2020-02-21 12:44 ` Peter Maydell
2020-02-21 13:09 ` Paolo Bonzini
2020-02-21 13:14 ` Peter Maydell
2020-02-21 18:15 ` Paolo Bonzini
2020-02-23 23:45 ` Gavin Shan [this message]
2020-02-23 23:26 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffbb0513-e24c-d41b-d511-a4bd2340d90a@redhat.com \
--to=gshan@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).