From: Eric Blake <eblake@redhat.com>
To: quintela@redhat.com, "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
berrange@redhat.com, qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] Add dbus-vmstate object
Date: Mon, 8 Jul 2019 11:11:01 -0500 [thread overview]
Message-ID: <ffbc4f91-db2c-b2de-3b0b-b68f350527d2@redhat.com> (raw)
In-Reply-To: <87r270dikm.fsf@trasno.org>
[-- Attachment #1.1: Type: text/plain, Size: 831 bytes --]
On 7/8/19 3:41 AM, Juan Quintela wrote:
> Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
>> When instanciated, this object will connect to the given D-Bus
>> bus. During migration, it will take the data from org.qemu.VMState1
>> instances.
>>
>> See documentation for further details.
>>
>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
>
> Before anything, I have no clue about DBUS and not a lot about glib, so
> don't expect anything else that questions on that front.
>
Ditto from me, but just noticing:
> Several questions:
>
>> +#define DBUS_VMSTATE_SIZE_LIMIT (1 << 20) /* 1mb */
Should this include units.h and spell it (1 * MiB)?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-08 16:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 7:24 [Qemu-devel] [PATCH 0/3] Add dbus-vmstate Marc-André Lureau
2019-07-08 7:24 ` [Qemu-devel] [PATCH 1/3] qemu-file: move qemu_{get, put}_counted_string() declarations Marc-André Lureau
2019-07-08 8:03 ` Juan Quintela
2019-07-08 7:24 ` [Qemu-devel] [PATCH 2/3] tests: add qtest_set_exit_status() Marc-André Lureau
2019-07-08 8:04 ` Juan Quintela
2019-07-17 11:50 ` Thomas Huth
2019-07-08 7:24 ` [Qemu-devel] [PATCH 3/3] Add dbus-vmstate object Marc-André Lureau
2019-07-08 8:41 ` Juan Quintela
2019-07-08 16:11 ` Eric Blake [this message]
2019-07-10 6:14 ` Paolo Bonzini
2019-07-10 8:05 ` Daniel P. Berrangé
2019-07-08 8:01 ` [Qemu-devel] [PATCH 0/3] Add dbus-vmstate no-reply
2019-07-08 9:35 ` no-reply
2019-07-08 15:44 ` Dr. David Alan Gilbert
2019-07-08 16:08 ` Daniel P. Berrangé
2019-07-08 16:04 ` Daniel P. Berrangé
2019-07-09 8:26 ` Marc-André Lureau
2019-07-09 9:01 ` Daniel P. Berrangé
2019-07-09 10:47 ` Marc-André Lureau
2019-07-10 9:10 ` Daniel P. Berrangé
2019-07-10 8:53 ` Paolo Bonzini
2019-07-10 9:03 ` Daniel P. Berrangé
2019-07-10 9:54 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffbc4f91-db2c-b2de-3b0b-b68f350527d2@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).