* [PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field
@ 2024-10-21 15:12 Philippe Mathieu-Daudé
2024-10-21 17:22 ` Pierrick Bouvier
2024-10-21 20:04 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-10-21 15:12 UTC (permalink / raw)
To: qemu-devel
Cc: Huacai Chen, Philippe Mathieu-Daudé, Aleksandar Rikalo,
Aurelien Jarno, Jiaxun Yang
The 'current_fpu' field is unused since commit f01be154589
("Move the active FPU registers into env again, and use more
TCG registers to access them").
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/mips/cpu.h | 1 -
target/mips/sysemu/machine.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/mips/cpu.h b/target/mips/cpu.h
index 6a4c4ea683a..3c235f39ffc 100644
--- a/target/mips/cpu.h
+++ b/target/mips/cpu.h
@@ -530,7 +530,6 @@ typedef struct CPUArchState {
CPUMIPSFPUContext active_fpu;
uint32_t current_tc;
- uint32_t current_fpu;
uint32_t SEGBITS;
uint32_t PABITS;
diff --git a/target/mips/sysemu/machine.c b/target/mips/sysemu/machine.c
index 91cd9f19002..8af11fd896b 100644
--- a/target/mips/sysemu/machine.c
+++ b/target/mips/sysemu/machine.c
@@ -242,7 +242,7 @@ const VMStateDescription vmstate_mips_cpu = {
/* CPU metastate */
VMSTATE_UINT32(env.current_tc, MIPSCPU),
- VMSTATE_UINT32(env.current_fpu, MIPSCPU),
+ VMSTATE_UNUSED(sizeof(uint32_t)), /* was current_fpu */
VMSTATE_INT32(env.error_code, MIPSCPU),
VMSTATE_UINTTL(env.btarget, MIPSCPU),
VMSTATE_UINTTL(env.bcond, MIPSCPU),
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field
2024-10-21 15:12 [PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field Philippe Mathieu-Daudé
@ 2024-10-21 17:22 ` Pierrick Bouvier
2024-10-21 20:04 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Pierrick Bouvier @ 2024-10-21 17:22 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Huacai Chen, Aleksandar Rikalo, Aurelien Jarno, Jiaxun Yang
On 10/21/24 08:12, Philippe Mathieu-Daudé wrote:
> The 'current_fpu' field is unused since commit f01be154589
> ("Move the active FPU registers into env again, and use more
> TCG registers to access them").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/mips/cpu.h | 1 -
> target/mips/sysemu/machine.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/mips/cpu.h b/target/mips/cpu.h
> index 6a4c4ea683a..3c235f39ffc 100644
> --- a/target/mips/cpu.h
> +++ b/target/mips/cpu.h
> @@ -530,7 +530,6 @@ typedef struct CPUArchState {
> CPUMIPSFPUContext active_fpu;
>
> uint32_t current_tc;
> - uint32_t current_fpu;
>
> uint32_t SEGBITS;
> uint32_t PABITS;
> diff --git a/target/mips/sysemu/machine.c b/target/mips/sysemu/machine.c
> index 91cd9f19002..8af11fd896b 100644
> --- a/target/mips/sysemu/machine.c
> +++ b/target/mips/sysemu/machine.c
> @@ -242,7 +242,7 @@ const VMStateDescription vmstate_mips_cpu = {
>
> /* CPU metastate */
> VMSTATE_UINT32(env.current_tc, MIPSCPU),
> - VMSTATE_UINT32(env.current_fpu, MIPSCPU),
> + VMSTATE_UNUSED(sizeof(uint32_t)), /* was current_fpu */
> VMSTATE_INT32(env.error_code, MIPSCPU),
> VMSTATE_UINTTL(env.btarget, MIPSCPU),
> VMSTATE_UINTTL(env.bcond, MIPSCPU),
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field
2024-10-21 15:12 [PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field Philippe Mathieu-Daudé
2024-10-21 17:22 ` Pierrick Bouvier
@ 2024-10-21 20:04 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2024-10-21 20:04 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Huacai Chen, Aleksandar Rikalo, Aurelien Jarno, Jiaxun Yang
On 10/21/24 08:12, Philippe Mathieu-Daudé wrote:
> The 'current_fpu' field is unused since commit f01be154589
> ("Move the active FPU registers into env again, and use more
> TCG registers to access them").
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> target/mips/cpu.h | 1 -
> target/mips/sysemu/machine.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-21 20:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-21 15:12 [PATCH] target/mips: Remove unused CPUMIPSState::current_fpu field Philippe Mathieu-Daudé
2024-10-21 17:22 ` Pierrick Bouvier
2024-10-21 20:04 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).