From: Richard Henderson <richard.henderson@linaro.org>
To: Mikhail Tyutin <m.tyutin@yadro.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: d.solovev@yadro.com, pbonzini@redhat.com,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] Fix SEGFAULT on getting physical address of MMIO region.
Date: Wed, 2 Aug 2023 09:09:54 -0700 [thread overview]
Message-ID: <ffcb690c-91d2-60f5-3e65-e0be204de7b8@linaro.org> (raw)
In-Reply-To: <bf8ae2fd-158a-57b6-6270-2e56b6506421@yadro.com>
On 8/2/23 06:08, Mikhail Tyutin wrote:
> The fix is to clear TLB_INVALID_MASK bit in tlb_addr, as it happens in other places e.g.
> load_helper().
>
> Signed-off-by: Dmitriy Solovev <d.solovev@yadro.com>
> Signed-off-by: Mikhail Tyutin <m.tyutin@yadro.com>
> ---
> accel/tcg/cputlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The other places in load_helper happen only directly after tlb_fill has succeeded. Here
you have no such guarantee.
I think perhaps the save_iotlb_data() call should be applied to loads as well, and then
tlb_plugin_lookup simplified.
r~
next prev parent reply other threads:[~2023-08-02 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 13:08 [PATCH] Fix SEGFAULT on getting physical address of MMIO region Mikhail Tyutin
2023-08-02 16:09 ` Richard Henderson [this message]
2023-08-09 13:17 ` Mikhail Tyutin
2023-08-09 14:41 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2023-07-03 16:16 Mikhail Tyutin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffcb690c-91d2-60f5-3e65-e0be204de7b8@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=d.solovev@yadro.com \
--cc=m.tyutin@yadro.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).