From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gye8w-0000Zy-Qk for qemu-devel@nongnu.org; Tue, 26 Feb 2019 09:55:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gye8v-0006hb-Qe for qemu-devel@nongnu.org; Tue, 26 Feb 2019 09:55:38 -0500 References: <20190218122710.23639-1-david@redhat.com> <20190218122710.23639-13-david@redhat.com> From: David Hildenbrand Message-ID: Date: Tue, 26 Feb 2019 15:55:29 +0100 MIME-Version: 1.0 In-Reply-To: <20190218122710.23639-13-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 12/15] s390x/tcg: Implement XxC and checks for most FP instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Thomas Huth , Halil Pasic , Christian Borntraeger , Janosch Frank , Cornelia Huck , Richard Henderson On 18.02.19 13:27, David Hildenbrand wrote: > With the floating-point extension facility > - CONVERT FROM LOGICAL > - CONVERT TO LOGICAL > - CONVERT TO FIXED > - CONVERT FROM FIXED > - LOAD FP INTEGER > have both, a rounding mode specification and the inexact-exception control > (XxC). Other instructions will be handled separatly. > > Check for valid rounding modes and forward also the XxC (via m4). To avoid > a lot of boilerplate code and changes to the helpers, combine both, the > m3 and m4 field in a combined 32 bit TCG variable. Perform checks at > a central place, taking in account if the m3 or m4 field was ignore > before the floating-point extension facility was introduced. > > Signed-off-by: David Hildenbrand > --- Here as well (from v2 review) Reviewed-by: Richard Henderson -- Thanks, David / dhildenb