Re: [Qemu-devel] [PATCH v2 14/17] target/openrisc: convert to TranslatorOps

[Richard Henderson <richard.henderson@linaro.org>]

On 04/07/2018 04:19 AM, Emilio G. Cota wrote:
> Notes:
> 
> - Changed the num_insns test in insn_start to check for
>   dc->base.num_insns > 1, since when tb_start is first
>   called in a TB, base.num_insns is already set to 1.
> 
> - Removed DISAS_NEXT from the switch in tb_stop; use
>   DISAS_TOO_MANY instead.
> 
> - Added an assert_not_reached on tb_stop for DISAS_NEXT
>   and the default case.
> 
> - Merged the two separate log_target_disas calls into the
>   disas_log op.
> 
> Cc: Stafford Horne <shorne@gmail.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  target/openrisc/translate.c | 163 +++++++++++++++++++++-----------------------
>  1 file changed, 79 insertions(+), 84 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~