From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3509CC61DA4 for ; Mon, 6 Feb 2023 13:03:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP196-0007bO-TX; Mon, 06 Feb 2023 08:02:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP18p-0007QI-Lu; Mon, 06 Feb 2023 08:02:43 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP18o-0006Rc-1u; Mon, 06 Feb 2023 08:02:39 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 316D0qCA025061; Mon, 6 Feb 2023 13:02:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=BhLI7FcTDjadHxnMvPsM3UVArQEhPdX7T+OjtiOG8Dw=; b=EetWxw7xmdYdFeEOzOM0NB+9ywmyNDwQ/IJf+wcTr+DGclnDm+xa1x8Bib+yu1W664PO 1gunMM4vJDp/72PlzjN6eYdLX0NohBMB5mrSltq7yXfv8roOSQgj/ak1naQmGVGGvqRa cZCZlpFpNRJlnC+Otw99STZjWA4BBsJv80jFKjYYId/VNmqL5UGIijRA/FHE8/6UivYf pmITYcHRWC99fBlflzN0zeMF4Ts8fcDreGoM/Ce5d9535ctdhv1F7/GBwI4Wv2ZyKs39 AAolLahbo1yIjiBccD5+eFQKK2alALFCvgcN1OlKF3m8xfP9uKv+dFec9d1vM+RiJ3qX mg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nk22681yn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Feb 2023 13:02:27 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 316D1IkZ027920; Mon, 6 Feb 2023 13:02:27 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3nk22681sa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Feb 2023 13:02:27 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 315N0mZc022560; Mon, 6 Feb 2023 13:02:16 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3nhemfje3x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Feb 2023 13:02:16 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 316D2CkA39715108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Feb 2023 13:02:12 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 63E7B20043; Mon, 6 Feb 2023 13:02:12 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1DC1720040; Mon, 6 Feb 2023 13:02:11 +0000 (GMT) Received: from [9.171.30.242] (unknown [9.171.30.242]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Feb 2023 13:02:11 +0000 (GMT) Message-ID: Date: Mon, 6 Feb 2023 14:02:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v15 06/11] s390x/cpu topology: interception of PTF instruction Content-Language: en-US To: Thomas Huth , qemu-s390x@nongnu.org Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com, pasic@linux.ibm.com, richard.henderson@linaro.org, david@redhat.com, cohuck@redhat.com, mst@redhat.com, pbonzini@redhat.com, kvm@vger.kernel.org, ehabkost@redhat.com, marcel.apfelbaum@gmail.com, eblake@redhat.com, armbru@redhat.com, seiden@linux.ibm.com, nrb@linux.ibm.com, nsg@linux.ibm.com, frankja@linux.ibm.com, berrange@redhat.com, clg@kaod.org References: <20230201132051.126868-1-pmorel@linux.ibm.com> <20230201132051.126868-7-pmorel@linux.ibm.com> <92533b03-f07e-736a-4e29-bcdf883f7ec4@redhat.com> From: Pierre Morel In-Reply-To: <92533b03-f07e-736a-4e29-bcdf883f7ec4@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 7qa0IDZ0-C72yDzK7A0YxqOadoa5jwG8 X-Proofpoint-ORIG-GUID: SQf9uUKTd32VF4eoGW6F7Z2It97lRmNz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-06_06,2023-02-06_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 mlxlogscore=999 clxscore=1015 mlxscore=0 bulkscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302060111 Received-SPF: pass client-ip=148.163.158.5; envelope-from=pmorel@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.148, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/6/23 12:38, Thomas Huth wrote: > On 01/02/2023 14.20, Pierre Morel wrote: >> When the host supports the CPU topology facility, the PTF >> instruction with function code 2 is interpreted by the SIE, >> provided that the userland hypervizor activates the interpretation > > s/hypervizor/hypervisor/ grr, I was pretty sure you already said that to me and I did change it... seems I did not. done now. > >> by using the KVM_CAP_S390_CPU_TOPOLOGY KVM extension. >> >> The PTF instructions with function code 0 and 1 are intercepted >> and must be emulated by the userland hypervizor. > > dito yes, thx. > >> During RESET all CPU of the configuration are placed in >> horizontal polarity. >> >> Signed-off-by: Pierre Morel >> --- > ... >>   /** >>    * s390_topology_reset: >>    * >>    * Generic reset for CPU topology, calls s390_topology_reset() >>    * s390_topology_reset() to reset the kernel Modified Topology >>    * change record. >> + * Then set global and all CPUs polarity to POLARITY_HORIZONTAL. > > You describe here already what's going to happen... > >>    */ >>   void s390_topology_reset(void) >>   { >>       s390_cpu_topology_reset(); >> +    /* Set global polarity to POLARITY_HORIZONTAL */ > > ... then here again ... > >> +    s390_topology.polarity = POLARITY_HORIZONTAL; > > ... and the code is (fortunately) also very self-exaplaining... > >> +    /* Set all CPU polarity to POLARITY_HORIZONTAL */ >> +    s390_topology_set_cpus_polarity(POLARITY_HORIZONTAL); > > ... so I'd rather drop the two comments within the function body. OK > >>   } > > (rest of the patch looks fine to me) > >  Thomas > Thanks. Regards, Pierre -- Pierre Morel IBM Lab Boeblingen