From: Thomas Huth <thuth@redhat.com>
To: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Mikhail Tyutin" <m.tyutin@yadro.com>,
"Aleksandr Anenkov" <a.anenkov@yadro.com>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v9 23/23] plugins: Support C++
Date: Wed, 11 Oct 2023 18:21:31 +0200 [thread overview]
Message-ID: <ffdd55c2-4ae9-4b1f-ac12-a9ad714c3f26@redhat.com> (raw)
In-Reply-To: <2c970c00-519c-4175-b0ca-9081c4aa0daf@daynix.com>
On 11/10/2023 17.48, Akihiko Odaki wrote:
> On 2023/10/11 17:51, Daniel P. Berrangé wrote:
>> On Wed, Oct 11, 2023 at 04:03:09PM +0900, Akihiko Odaki wrote:
>>> Make qemu-plugin.h consumable for C++ platform.
>>>
>>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>>> ---
>>> docs/devel/tcg-plugins.rst | 4 ++++
>>> meson.build | 2 +-
>>> include/qemu/qemu-plugin.h | 4 ++++
>>> tests/plugin/cc.cc | 16 ++++++++++++++++
>>> tests/plugin/meson.build | 5 +++++
>>> tests/tcg/Makefile.target | 3 +--
>>> 6 files changed, 31 insertions(+), 3 deletions(-)
>>> create mode 100644 tests/plugin/cc.cc
>>>
>>> diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst
>>> index c9f8b27590..984d8012e9 100644
>>> --- a/docs/devel/tcg-plugins.rst
>>> +++ b/docs/devel/tcg-plugins.rst
>>> @@ -283,6 +283,10 @@ run::
>>> 160 1 0
>>> 135 1 0
>>> +- contrib/plugins/cc.cc
>>> +
>>> +A pure test plugin to ensure that the plugin API is compatible with C++.
>>> +
>>
>> IMHO we don't need to be adding a test just to prove the
>> existance of the G_BEGIN_DECLS/G_END_DECLS macros in the
>> plugin header.
>
> Strictly speaking, if you include this header file from C++, the code will
> be interpreted as C++ instead of C but with C linkage. That worries me that
> the header file may get something not allowed in C++ in the future.
I think it should be enough if you add the G_BEGIN_DECLS/G_END_DECLS macros
here. QEMU is a C project, and it was quite difficult to get rid of the C++
code again, so please don't soften the check in meson.build and don't
introduce new .cc files.
If you have some code somewhere that uses C++ for plugins, I think it would
be better to add a regression test there instead.
Thomas
next prev parent reply other threads:[~2023-10-11 16:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 7:02 [PATCH v9 00/23] plugins: Allow to read registers Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 01/23] target/riscv: Move MISA limits to class Akihiko Odaki
2023-10-11 15:23 ` Alex Bennée
2023-10-12 6:01 ` Akihiko Odaki
2023-10-11 16:04 ` Alex Bennée
2023-10-12 19:10 ` Daniel Henrique Barboza
2023-10-12 21:04 ` Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 02/23] target/riscv: Remove misa_mxl validation Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 03/23] target/riscv: Validate misa_mxl_max only once Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 04/23] gdbstub: Add num_regs member to GDBFeature Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 05/23] gdbstub: Introduce gdb_find_static_feature() Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 06/23] gdbstub: Introduce GDBFeatureBuilder Akihiko Odaki
2023-10-11 15:39 ` Alex Bennée
2023-10-11 7:02 ` [PATCH v9 07/23] target/arm: Use GDBFeature for dynamic XML Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 08/23] target/ppc: " Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 09/23] target/riscv: " Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 10/23] gdbstub: Use GDBFeature for gdb_register_coprocessor Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 11/23] gdbstub: Use GDBFeature for GDBRegisterState Akihiko Odaki
2023-10-11 15:57 ` Alex Bennée
2023-10-11 7:02 ` [PATCH v9 12/23] gdbstub: Change gdb_get_reg_cb and gdb_set_reg_cb Akihiko Odaki
2023-10-11 7:02 ` [PATCH v9 13/23] gdbstub: Simplify XML lookup Akihiko Odaki
2023-10-11 7:03 ` [PATCH v9 14/23] gdbstub: Infer number of core registers from XML Akihiko Odaki
2023-10-11 7:03 ` [PATCH v9 15/23] hw/core/cpu: Remove gdb_get_dynamic_xml member Akihiko Odaki
2023-10-11 7:03 ` [PATCH v9 16/23] gdbstub: Add members to identify registers to GDBFeature Akihiko Odaki
2023-10-11 7:03 ` [PATCH v9 17/23] gdbstub: Expose functions to read registers Akihiko Odaki
2023-10-11 7:03 ` [PATCH v9 18/23] cpu: Call plugin hooks only when ready Akihiko Odaki
2023-10-11 7:03 ` [PATCH v9 19/23] plugins: Remove an extra parameter Akihiko Odaki
2023-10-11 7:03 ` [PATCH v9 20/23] plugins: Use different helpers when reading registers Akihiko Odaki
2023-10-11 7:03 ` [PATCH v9 21/23] plugins: Allow to read registers Akihiko Odaki
2023-10-11 7:03 ` [PATCH v9 22/23] contrib/plugins: Allow to log registers Akihiko Odaki
2023-10-11 7:03 ` [PATCH v9 23/23] plugins: Support C++ Akihiko Odaki
2023-10-11 8:51 ` Daniel P. Berrangé
2023-10-11 15:48 ` Akihiko Odaki
2023-10-11 16:21 ` Thomas Huth [this message]
2023-10-11 16:42 ` Akihiko Odaki
2023-10-11 16:53 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffdd55c2-4ae9-4b1f-ac12-a9ad714c3f26@redhat.com \
--to=thuth@redhat.com \
--cc=a.anenkov@yadro.com \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=erdnaxe@crans.org \
--cc=m.tyutin@yadro.com \
--cc=ma.mandourr@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).