From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95247C04A6B for ; Fri, 10 May 2019 16:33:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A6F8208C3 for ; Fri, 10 May 2019 16:33:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A6F8208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:46390 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP8Sb-00043Y-Ga for qemu-devel@archiver.kernel.org; Fri, 10 May 2019 12:33:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hP8Ft-00072o-Lb for qemu-devel@nongnu.org; Fri, 10 May 2019 12:20:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hP8Fs-00048u-KD for qemu-devel@nongnu.org; Fri, 10 May 2019 12:20:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55754) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hP8Fq-00046P-0F; Fri, 10 May 2019 12:20:14 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4CDC130842A9; Fri, 10 May 2019 16:20:13 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-72.ams2.redhat.com [10.36.116.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 679E4101E267; Fri, 10 May 2019 16:20:04 +0000 (UTC) To: Max Reitz , qemu-devel@nongnu.org References: <20190502084506.8009-1-thuth@redhat.com> <20190502084506.8009-8-thuth@redhat.com> <413645a6-385c-e112-ad9c-8525ef3d9e52@redhat.com> <60bbf536-fd61-aade-dbff-f0914615c412@redhat.com> <3f86e4a2-a985-7c70-d8ea-fe28740b4c1b@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: Date: Fri, 10 May 2019 18:20:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3f86e4a2-a985-7c70-d8ea-fe28740b4c1b@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 10 May 2019 16:20:13 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3 7/7] tests: Run the iotests during "make check" again X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Ed Maste , qemu-block@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Markus Armbruster , Christophe Fergeau , Wainer dos Santos Moschetta , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Li-Wen Hsu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/05/2019 15.47, Max Reitz wrote: > On 10.05.19 15:36, Thomas Huth wrote: >> On 10/05/2019 15.34, Max Reitz wrote: >>> On 10.05.19 06:29, Thomas Huth wrote: >>>> On 09/05/2019 20.08, Max Reitz wrote: >>>>> On 02.05.19 10:45, Thomas Huth wrote: >>>>>> People often forget to run the iotests before submitting patches o= r >>>>>> pull requests - this is likely due to the fact that we do not run = the >>>>>> tests during our mandatory "make check" tests yet. Now that we've = got >>>>>> a proper "auto" group of iotests that should be fine to run in eve= ry >>>>>> environment, we can enable the iotests during "make check" again b= y >>>>>> running the "auto" tests by default from the check-block.sh script= . >>>>>> >>>>>> Some cases still need to be checked first, though: iotests need ba= sh >>>>>> and GNU sed (otherwise they fail), and if gprof is enabled, it spo= ils >>>>>> the output of some test cases causing them to fail. So if we detec= t >>>>>> that one of the required programs is missing or that gprof is enab= led, >>>>>> we still have to skip the iotests to avoid failures. >>>>>> >>>>>> And finally, since we are using check-block.sh now again, this pat= ch also >>>>>> removes the qemu-iotests-quick.sh script since we do not need that= anymore >>>>>> (and having two shell wrapper scripts around the block tests seem >>>>>> rather confusing than helpful). >>>>>> >>>>>> Signed-off-by: Thomas Huth >>>>>> --- >>>>>> tests/Makefile.include | 8 +++---- >>>>>> tests/check-block.sh | 44 ++++++++++++++++++++++++++++----= ----- >>>>>> tests/qemu-iotests-quick.sh | 8 ------- >>>>>> 3 files changed, 38 insertions(+), 22 deletions(-) >>>>>> delete mode 100755 tests/qemu-iotests-quick.sh >>>>> >>>>> Can I interest you in a Makefile target that explicitly excludes >>>>> check-block? I run the iotests anyway, but I also run make check. >>>>> Running some iotests twice would be a bit pointless. >>>> >>>> Can't you simply run >>>> >>>> ./check -qcow2 -x auto >>>> >>>> instead? >>> >>> I don=E2=80=99t run just qcow2 tests. I run qcow2, qcow2 with compat= =3D0.10, >>> qcow2 with refcount_bits=3D1, raw, nbd, qed, vmdk, vhdx, ... A lot. >>> >>> So for which of the protocol/format combinations do I exclude the aut= o >>> group? check-block.sh says it runs raw, qcow2, qed, vmdk, and vpc. = But >>> may that not be subject to change? >> >> With my patch series, the auto group is only used for qcow2. >=20 > And that is not subject to change? Like, maybe someone wants to add nb= d > in the future? The current set of qcow2 auto tests takes already quite a while, so I don't think that this will change soon. And if the "normal" users want to run more tests, they can simply use "make check SPEED=3Dslow" or SPEED=3Dthorough, so IMHO no need to extend = the quick default list right now. > I mean, I have a test branch anyway which collects a number of patches > on top of master that make everything pass more or less reliably for me > (11 patches currently...). I suppose I can just revert your patch on > top of that. But that doesn=E2=80=99t feel right. Hmm, sure, non-upstream patches are always a bad thing. But I still don't see why you really need an extra Makefile target for this. In the worst case, you could also simply change your script to run something this instead: make $(grep ^check: tests/Makefile.include | sed s/check-block//) ? Thomas