From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C3CCC04A6B for ; Fri, 10 May 2019 19:16:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C115217D6 for ; Fri, 10 May 2019 19:16:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qjmNBCyD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C115217D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:48856 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPB0Q-0007th-Fs for qemu-devel@archiver.kernel.org; Fri, 10 May 2019 15:16:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPAzM-0007PN-0Q for qemu-devel@nongnu.org; Fri, 10 May 2019 15:15:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPAzL-0005kh-5W for qemu-devel@nongnu.org; Fri, 10 May 2019 15:15:23 -0400 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:42243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPAzK-0005hh-VN for qemu-devel@nongnu.org; Fri, 10 May 2019 15:15:23 -0400 Received: by mail-pl1-x643.google.com with SMTP id x15so3247062pln.9 for ; Fri, 10 May 2019 12:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8yfIZyFKLrRsNknpRX42NFD+HKsnDmkaRzzlwChgWL0=; b=qjmNBCyD33sHTAVcOzv8kkTpThJM9vMeUM50zYv8Re4LcymmmjzYCbIMklk+IGy7Gi i9VmlRY7GrrbtUD4vLTenK/xzFRMbUtxXxvchQXpZ25w5PzHq5e8RZW0LsAvlb1fxeu2 BXGWi8NjGt64di0p+0ENkETQK1wDif0L6drbpbIlSiIOvEk6Olo6APKgQDdcA+qYX+xM GQp7qfNCH+czBylH2640d4layMoI9KvKc4pbcfLYRWYrFZsgS8ya2KEn8m4UBvG/Q+H+ 14DvDa52YcVEJv6KIraHfThh3gqNqnMAytvH+qnZF5W18uvxa0o12V7V8NQfus7F8EBM Y8kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8yfIZyFKLrRsNknpRX42NFD+HKsnDmkaRzzlwChgWL0=; b=qYXxqB1b4mff1mWgFgGlAQgABj8+Ud8OCc3KKMypVVsQezm9RpDRAvo0zV41PDqwX5 jqCViHShef9siGxAZVetJsQpmvJnAxvq/R6GwAoUstl8+VHGzQB80XzpYLJHLPp9sstZ 6NqqsAfswbxBR5zIldPv23DjnxVr5ywH9wO+CcNSzaDAzasTu09PVb8QGe33JvHsoNi7 SDVC285sJU3kQ/DM/krC1ofgkUgbzt5fUb3RuCgmosJjnFFuzBbLkYr/Hi1Ro/PFHBsh X/KRhrBZ8mA6AhYN8Y/v8vlTHsaho/yyvzgzwwv10yFMPsbuws1EXG7NIPDc7cI8rBoZ QzJQ== X-Gm-Message-State: APjAAAVojJQxiuqVdB45uRld51BPc3ju2gz+ozXEH57+O7vjldI9ykjd SLEdBN3SZqgS4fh9H+/nCBiVKQ== X-Google-Smtp-Source: APXvYqzXqGJ/BIOaxvgMUV+Ufm+G1k2EC7vR1iwVWj2Zl6SmjthSJHteA0ltAguNE4MgqdAWtfSvpg== X-Received: by 2002:a17:902:28e4:: with SMTP id f91mr15035650plb.321.1557515721756; Fri, 10 May 2019 12:15:21 -0700 (PDT) Received: from [192.168.1.11] (97-113-13-231.tukw.qwest.net. [97.113.13.231]) by smtp.gmail.com with ESMTPSA id 13sm7696808pfi.172.2019.05.10.12.15.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 May 2019 12:15:20 -0700 (PDT) To: Eduardo Habkost , qemu-devel@nongnu.org References: <20190510185620.15757-1-ehabkost@redhat.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Fri, 10 May 2019 12:15:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190510185620.15757-1-ehabkost@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::643 Subject: Re: [Qemu-devel] [PATCH] monitor: Call mon_get_cpu() only once at hmp_gva2gpa() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. David Alan Gilbert" , Stefan Hajnoczi , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/10/19 11:56 AM, Eduardo Habkost wrote: > hmp_gva2gpa() calls mon_get_cpu() twice, which is unnecessary. > Not an actual bug, but this is reported as a defect by Coverity > Scan (CID 1401346). > > Signed-off-by: Eduardo Habkost > --- > monitor.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson I was about to send the same patch. ;-) r~