[Qemu-devel] qemu softmmu_header.h

[Qemu-devel] qemu softmmu_header.h

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	08/01/21 15:07:18

Modified files:
	.              : softmmu_header.h 

Log message:
	fixed register constraint

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/softmmu_header.h?cvsroot=qemu&r1=1.18&r2=1.19

Re: [Qemu-devel] qemu softmmu_header.h

[Johannes Schindelin]

Hi,

On Mon, 21 Jan 2008, Fabrice Bellard wrote:

> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Fabrice Bellard <bellard>	08/01/21 15:07:18
> 
> Modified files:
> 	.              : softmmu_header.h 
> 
> Log message:
> 	fixed register constraint
> 
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/softmmu_header.h?cvsroot=qemu&r1=1.18&r2=1.19

As has been pointed out already, this breaks compilation _at least_ with 
gcc 3.4.2 on MinGW.

Thanks,
Dscho

Re: [Qemu-devel] qemu softmmu_header.h

[C.W. Betts]

Builds fine on MinGW gcc 3.4.5
----- Original Message ----- 
From: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
To: "Fabrice Bellard" <fabrice@bellard.org>
Cc: <qemu-devel@nongnu.org>
Sent: Monday, January 21, 2008 8:23 AM
Subject: Re: [Qemu-devel] qemu softmmu_header.h


> Hi,
>
> On Mon, 21 Jan 2008, Fabrice Bellard wrote:
>
>> CVSROOT: /sources/qemu
>> Module name: qemu
>> Changes by: Fabrice Bellard <bellard> 08/01/21 15:07:18
>>
>> Modified files:
>> .              : softmmu_header.h
>>
>> Log message:
>> fixed register constraint
>>
>> CVSWeb URLs:
>> http://cvs.savannah.gnu.org/viewcvs/qemu/softmmu_header.h?cvsroot=qemu&r1=1.18&r2=1.19
>
> As has been pointed out already, this breaks compilation _at least_ with
> gcc 3.4.2 on MinGW.
>
> Thanks,
> Dscho
>
>
>
> 

Re: [Qemu-devel] qemu softmmu_header.h

[Johannes Schindelin]

Hi,

On Mon, 21 Jan 2008, C.W. Betts wrote:

> Builds fine on MinGW gcc 3.4.5

Maybe it was a combination of changes?  I don't remember.

Just to make sure, I will recompile and test again, but that will have to 
wait until after work.

Ciao,
Dscho

P.S.: do other posters also get that SMTP error while sending to 
consul@...?

[Qemu-devel] Re: qemu softmmu_header.h

[consul]

Sorry for that. consul at collegeclub was my old spam-get-all account.
Now the reply address is valid, (not void yet :). I'm not sure if this post 
will get through though.

"Johannes Schindelin" <Johannes.Schindelin@gmx.de> wrote in message 
news:alpine.LSU.1.00.0801211607100.5731@racer.site...
> Hi,
>
> On Mon, 21 Jan 2008, C.W. Betts wrote:
>
>> Builds fine on MinGW gcc 3.4.5
>
> Maybe it was a combination of changes?  I don't remember.
>
> Just to make sure, I will recompile and test again, but that will have to
> wait until after work.
>
> Ciao,
> Dscho
>
> P.S.: do other posters also get that SMTP error while sending to
> consul@...?
>
>
> 

Re: [Qemu-devel] qemu softmmu_header.h

[Fabrice Bellard]

Johannes Schindelin wrote:
> Hi,
> 
> On Mon, 21 Jan 2008, Fabrice Bellard wrote:
> 
>> CVSROOT:	/sources/qemu
>> Module name:	qemu
>> Changes by:	Fabrice Bellard <bellard>	08/01/21 15:07:18
>>
>> Modified files:
>> 	.              : softmmu_header.h 
>>
>> Log message:
>> 	fixed register constraint
>>
>> CVSWeb URLs:
>> http://cvs.savannah.gnu.org/viewcvs/qemu/softmmu_header.h?cvsroot=qemu&r1=1.18&r2=1.19
> 
> As has been pointed out already, this breaks compilation _at least_ with 
> gcc 3.4.2 on MinGW.

If it does, it is a very weird gcc bug. The previous code was clearly 
incorrect.

Fabrice.

Re: [Qemu-devel] qemu softmmu_header.h

[Johannes Schindelin]

Hi,

On Mon, 21 Jan 2008, Fabrice Bellard wrote:

> Johannes Schindelin wrote:
> 
> > On Mon, 21 Jan 2008, Fabrice Bellard wrote:
> > 
> > > CVSROOT:	/sources/qemu
> > > Module name:	qemu
> > > Changes by:	Fabrice Bellard <bellard>	08/01/21 15:07:18
> > > 
> > > Modified files:
> > > 	.              : softmmu_header.h 
> > > Log message:
> > > 	fixed register constraint
> > > 
> > > CVSWeb URLs:
> > > http://cvs.savannah.gnu.org/viewcvs/qemu/softmmu_header.h?cvsroot=qemu&r1=1.18&r2=1.19
> > 
> > As has been pointed out already, this breaks compilation _at least_ 
> > with gcc 3.4.2 on MinGW.
> 
> If it does, it is a very weird gcc bug. The previous code was clearly 
> incorrect.

Ha!  Your code compiles.  And you know why?  Because you only said "#if 
DATA_SIZE == 1", and did not add " || DATA_SIZE == 2".

Now, I am out of my depth here; no idea what _should_ be correct.

Ciao,
Dscho

P.S.: Oh, and I ran a small Linux image with it, too, so it appears that 
your patch does _not_ break anything.  IOW I was wrong.  Sorry.