From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JyrRU-00026E-0S
	for qemu-devel@nongnu.org; Wed, 21 May 2008 12:45:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JyrRS-00024A-Sz
	for qemu-devel@nongnu.org; Wed, 21 May 2008 12:45:31 -0400
Received: from [199.232.76.173] (port=57225 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JyrRS-00023p-IY
	for qemu-devel@nongnu.org; Wed, 21 May 2008 12:45:30 -0400
Received: from main.gmane.org ([80.91.229.2]:47491 helo=ciao.gmane.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1JyrRR-0001P7-RH
	for qemu-devel@nongnu.org; Wed, 21 May 2008 12:45:30 -0400
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1JyrRP-0007X5-NQ
	for qemu-devel@nongnu.org; Wed, 21 May 2008 16:45:27 +0000
Received: from 204.147.152.1 ([204.147.152.1])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 21 May 2008 16:45:27 +0000
Received: from void by 204.147.152.1 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 21 May 2008 16:45:27 +0000
From: "consul" <void@aleksoft.net>
Date: Wed, 21 May 2008 09:45:16 -0700
Message-ID: <g11jiu$gpm$1@ger.gmane.org>
References: <E1JxQys-000218-7v@cvs.savannah.gnu.org><g0uvq6$521$1@ger.gmane.org><18484.8433.525986.172414@mariner.uk.xensource.com>
	<200805211507.05887.paul@codesourcery.com>
Sender: news <news@ger.gmane.org>
Subject: [Qemu-devel] Re: Re: [4476] musicpal: Improve button handling
	(JanKiszka).
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


"Paul Brook" <paul@codesourcery.com> wrote in message 
news:200805211507.05887.paul@codesourcery.com...

>> Surely this should be in osdep.h as a conditional definition of sleep.
>
> The real bug is that we're using sleep() in the first place :-)
>

IMHO committed code should at least compile on all supported platforms. Even 
a temporary fix is better than no fix at all. Using the sleep is certainly 
not the best solution and Jan already proposed another patch without it, see 
[RFC][PATCH 2/2] MusicPal: Add specific -hold-buttonoption, without the 
sleep function, but as of today, the latest qemu svn (4511) does not compile 
on Windows, and that's a real bug.

Alex.