From: Charles Duffy <Charles_Duffy@messageone.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] only check RCTL_EN in e1000_can_receive()
Date: Tue, 05 Aug 2008 15:35:07 -0500 [thread overview]
Message-ID: <g7adi4$as5$1@ger.gmane.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
e1000_receive() has code to raise a receive overflow interrupt when the
receive buffer head and tail match. However, with the present
implementation of e1000_can_receive(), this code is unreachable -- and
etherboot breaks as a result.
The attached quick-and-dirty patch fixes etherboot for e1000, and does
not appear to break post-boot functionality.
[-- Attachment #2: qemu-e1000-receive-overflow-handler-reachability.patch --]
[-- Type: text/x-diff, Size: 430 bytes --]
Signed-off-by: Charles Duffy <charles_duffy@messageone.com>
Index: hw/e1000.c
===================================================================
--- hw/e1000.c (revision 4985)
+++ hw/e1000.c (working copy)
@@ -524,8 +524,7 @@
{
E1000State *s = opaque;
- return (!(s->mac_reg[RCTL] & E1000_RCTL_EN) ||
- s->mac_reg[RDH] != s->mac_reg[RDT]);
+ return (s->mac_reg[RCTL] & E1000_RCTL_EN);
}
static void
next reply other threads:[~2008-08-05 20:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 20:35 Charles Duffy [this message]
2008-08-06 14:13 ` [Qemu-devel] [PATCH] only check RCTL_EN in e1000_can_receive() Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='g7adi4$as5$1@ger.gmane.org' \
--to=charles_duffy@messageone.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).