From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LAT77-0001lt-CE
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 12:44:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LAT75-0001iy-G4
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 12:44:44 -0500
Received: from [199.232.76.173] (port=51969 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LAT75-0001il-6L
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 12:44:43 -0500
Received: from main.gmane.org ([80.91.229.2]:50650 helo=ciao.gmane.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1LAT74-0006ig-Lo
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 12:44:42 -0500
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1LAT6z-000778-9K
	for qemu-devel@nongnu.org; Wed, 10 Dec 2008 17:44:37 +0000
Received: from 78.158.192.230 ([78.158.192.230])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 10 Dec 2008 17:44:37 +0000
Received: from vladimir by 78.158.192.230 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 10 Dec 2008 17:44:37 +0000
From: Vladimir Prus <vladimir@codesourcery.com>
Date: Wed, 10 Dec 2008 20:44:26 +0300
Message-ID: <ghov5q$ev1$1@ger.gmane.org>
References: <200812011859.35859.paul@codesourcery.com>
	<200812021647.mB2Gldoe003402@smtp11.dti.ne.jp>
	<200812021710.45302.paul@codesourcery.com>
	<200812031437.mB3EbpeU009295@smtp11.dti.ne.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7Bit
Sender: news <news@ger.gmane.org>
Subject: [Qemu-devel] Re: [PATCH] sh4: Followup to commit #5849 "Change MMIO
	callbacks..."
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

takasi-y@ops.dti.ne.jp wrote:

> Thank you, Paul.
> 
>> You should not rely on overlapping regions doing anything sensible.
> OK. fixed.
> 
>> Proably simpler to just use a single region for both.
> Ah, that's right. Now the code is very simple (than I have expected).
> 
> Here is the patch. Please apply it.
> 
> Fixes to be needed for commit #5849 "Change MMIO callbacks..."
>   hw/sh7750.c:
>    - Divide region of CPU control registers to avoid overlapping
>      to peripheral modules.
>    - Delete unused var "icr", which had moved to hw/sh_intc.c.

Does sh_intc.c actually handle icr right now? Although I have a local
patch that makes it handle icr0 as well as LVLMODE, I don't see this
patch in SVN HEAD of qemu.

- Volodya