qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] SIGSEGV when USE_KQEMU is defined
@ 2009-02-20  0:14 Consul
  2009-02-20 17:14 ` [Qemu-devel] " Consul
  2009-03-03  6:28 ` [Qemu-devel] " Aurelien Jarno
  0 siblings, 2 replies; 3+ messages in thread
From: Consul @ 2009-02-20  0:14 UTC (permalink / raw)
  To: qemu-devel

Signed-off-by: Alex Ivanov <void@aleksoft.net>

$ svn diff
Index: block.c
===================================================================
--- block.c     (revision 6628)
+++ block.c     (working copy)
@@ -1263,7 +1263,7 @@
      if (!s->is_write) {
          qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
      }
-    qemu_free(s->bounce);
+    qemu_vfree(s->bounce);
      s->this_aiocb->cb(s->this_aiocb->opaque, ret);
      qemu_aio_release(s->this_aiocb);
  }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Qemu-devel] Re: [PATCH] SIGSEGV when USE_KQEMU is defined
  2009-02-20  0:14 [Qemu-devel] [PATCH] SIGSEGV when USE_KQEMU is defined Consul
@ 2009-02-20 17:14 ` Consul
  2009-03-03  6:28 ` [Qemu-devel] " Aurelien Jarno
  1 sibling, 0 replies; 3+ messages in thread
From: Consul @ 2009-02-20 17:14 UTC (permalink / raw)
  To: qemu-devel

Consul wrote:
> Signed-off-by: Alex Ivanov <void@aleksoft.net>
> 
> $ svn diff
> Index: block.c
> ===================================================================
> --- block.c     (revision 6628)
> +++ block.c     (working copy)
> @@ -1263,7 +1263,7 @@
>      if (!s->is_write) {
>          qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
>      }
> -    qemu_free(s->bounce);
> +    qemu_vfree(s->bounce);
>      s->this_aiocb->cb(s->this_aiocb->opaque, ret);
>      qemu_aio_release(s->this_aiocb);
>  }
> 

On Windows s->bounce = qemu_memalign(512, nb_sectors * 512);
translates to VirtualAlloc and should be freed with VirtualFree (what qemu_vfree does).

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] SIGSEGV when USE_KQEMU is defined
  2009-02-20  0:14 [Qemu-devel] [PATCH] SIGSEGV when USE_KQEMU is defined Consul
  2009-02-20 17:14 ` [Qemu-devel] " Consul
@ 2009-03-03  6:28 ` Aurelien Jarno
  1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2009-03-03  6:28 UTC (permalink / raw)
  To: Alex Ivanov; +Cc: qemu-devel

On Thu, Feb 19, 2009 at 04:14:25PM -0800, Consul wrote:
> Signed-off-by: Alex Ivanov <void@aleksoft.net>
>
> $ svn diff
> Index: block.c
> ===================================================================
> --- block.c     (revision 6628)
> +++ block.c     (working copy)
> @@ -1263,7 +1263,7 @@
>      if (!s->is_write) {
>          qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
>      }
> -    qemu_free(s->bounce);
> +    qemu_vfree(s->bounce);
>      s->this_aiocb->cb(s->this_aiocb->opaque, ret);
>      qemu_aio_release(s->this_aiocb);
>  }

Thanks, applied.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-03-03  6:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-20  0:14 [Qemu-devel] [PATCH] SIGSEGV when USE_KQEMU is defined Consul
2009-02-20 17:14 ` [Qemu-devel] " Consul
2009-03-03  6:28 ` [Qemu-devel] " Aurelien Jarno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).