* [Qemu-devel] [Patch] [Resend] Fix sigsegv on Windows host
@ 2009-02-27 22:55 Consul
2009-03-02 20:37 ` Robert Riebisch
0 siblings, 1 reply; 4+ messages in thread
From: Consul @ 2009-02-27 22:55 UTC (permalink / raw)
To: qemu-devel
Is there a reason this patch has not been applied? I'm still getting sigsegv early in the boot of Windows images without it.
s->bounce has been VirtualAlloc'ed and should be VirtualFree'ed.
signed-off-by Alex Ivanov <void@aleksoft.net>
--- block.c (revision 6653)
+++ block.c (working copy)
@@ -1263,7 +1263,7 @@
if (!s->is_write) {
qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
}
- qemu_free(s->bounce);
+ qemu_vfree(s->bounce);
s->this_aiocb->cb(s->this_aiocb->opaque, ret);
qemu_aio_release(s->this_aiocb);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Patch] [Resend] Fix sigsegv on Windows host
2009-02-27 22:55 [Qemu-devel] [Patch] [Resend] Fix sigsegv on Windows host Consul
@ 2009-03-02 20:37 ` Robert Riebisch
2009-03-02 21:20 ` Anthony Liguori
0 siblings, 1 reply; 4+ messages in thread
From: Robert Riebisch @ 2009-03-02 20:37 UTC (permalink / raw)
To: qemu-devel
Consul wrote:
> Is there a reason this patch has not been applied? I'm still getting sigsegv early in the boot of Windows images without it.
> s->bounce has been VirtualAlloc'ed and should be VirtualFree'ed.
>
> signed-off-by Alex Ivanov <void@aleksoft.net>
>
> --- block.c (revision 6653)
> +++ block.c (working copy)
> @@ -1263,7 +1263,7 @@
> if (!s->is_write) {
> qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
> }
> - qemu_free(s->bounce);
> + qemu_vfree(s->bounce);
> s->this_aiocb->cb(s->this_aiocb->opaque, ret);
> qemu_aio_release(s->this_aiocb);
> }
Could someone please apply this to SVN?! Thanks!
Robert Riebisch
--
BTTR Software
http://www.bttr-software.de/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Patch] [Resend] Fix sigsegv on Windows host
2009-03-02 20:37 ` Robert Riebisch
@ 2009-03-02 21:20 ` Anthony Liguori
2009-03-03 19:35 ` Robert Riebisch
0 siblings, 1 reply; 4+ messages in thread
From: Anthony Liguori @ 2009-03-02 21:20 UTC (permalink / raw)
To: qemu-devel
Robert Riebisch wrote:
> Consul wrote:
>
>
>> Is there a reason this patch has not been applied? I'm still getting sigsegv early in the boot of Windows images without it.
>> s->bounce has been VirtualAlloc'ed and should be VirtualFree'ed.
>>
>> signed-off-by Alex Ivanov <void@aleksoft.net>
>>
>> --- block.c (revision 6653)
>> +++ block.c (working copy)
>> @@ -1263,7 +1263,7 @@
>> if (!s->is_write) {
>> qemu_iovec_from_buffer(s->iov, s->bounce, s->iov->size);
>> }
>> - qemu_free(s->bounce);
>> + qemu_vfree(s->bounce);
>> s->this_aiocb->cb(s->this_aiocb->opaque, ret);
>> qemu_aio_release(s->this_aiocb);
>> }
>>
>
> Could someone please apply this to SVN?! Thanks!
>
It's in my queue to be applied before the release so it'll be there soon.
Regards,
Anthony Liguori
> Robert Riebisch
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Patch] [Resend] Fix sigsegv on Windows host
2009-03-02 21:20 ` Anthony Liguori
@ 2009-03-03 19:35 ` Robert Riebisch
0 siblings, 0 replies; 4+ messages in thread
From: Robert Riebisch @ 2009-03-03 19:35 UTC (permalink / raw)
To: qemu-devel
Anthony Liguori wrote:
>> Could someone please apply this to SVN?! Thanks!
>>
>
> It's in my queue to be applied before the release so it'll be there soon.
Thanks! :-)
Robert Riebisch
--
BTTR Software
http://www.bttr-software.de/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-03-03 19:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-27 22:55 [Qemu-devel] [Patch] [Resend] Fix sigsegv on Windows host Consul
2009-03-02 20:37 ` Robert Riebisch
2009-03-02 21:20 ` Anthony Liguori
2009-03-03 19:35 ` Robert Riebisch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).