From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lu735-00045j-Eo for qemu-devel@nongnu.org; Wed, 15 Apr 2009 11:29:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lu730-0003xK-C8 for qemu-devel@nongnu.org; Wed, 15 Apr 2009 11:29:14 -0400 Received: from [199.232.76.173] (port=48863 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lu730-0003wm-4p for qemu-devel@nongnu.org; Wed, 15 Apr 2009 11:29:10 -0400 Received: from main.gmane.org ([80.91.229.2]:35923 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lu72z-0003ot-4k for qemu-devel@nongnu.org; Wed, 15 Apr 2009 11:29:09 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Lu72x-00054N-H3 for qemu-devel@nongnu.org; Wed, 15 Apr 2009 15:29:07 +0000 Received: from 204.147.152.1 ([204.147.152.1]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Apr 2009 15:29:07 +0000 Received: from void by 204.147.152.1 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Apr 2009 15:29:07 +0000 From: Consul Date: Wed, 15 Apr 2009 08:28:56 -0700 Message-ID: References: <1239789151-23552-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In-Reply-To: <1239789151-23552-1-git-send-email-kwolf@redhat.com> Sender: news Subject: [Qemu-devel] Re: [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2 Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Kevin Wolf wrote: > This patch fixes a qcow2 corruption bug introduced in SVN Rev 5861. L2 tables > are big endian, so entries must be converted before being passed to functions. > Excellent! I think it is this bug who bit me more than once. Acked-by: Alex Ivanov > This bug is easy to trigger. The following script will create and destroy a > qcow2 image (the header is gone after three loop iterations): > > #!/bin/bash > qemu-img create -f qcow2 test.qcow 1M > for i in $(seq 1 10); do > qemu-system-x86_64 -hda test.qcow -monitor stdio > /dev/null 2>&1 < savevm test-$i > quit > EOF > done > > Signed-off-by: Kevin Wolf > --- > block-qcow2.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/block-qcow2.c b/block-qcow2.c > index da8fb42..985214f 100644 > --- a/block-qcow2.c > +++ b/block-qcow2.c > @@ -1007,7 +1007,7 @@ static int alloc_cluster_link_l2(BlockDriverState *bs, uint64_t cluster_offset, > goto err; > > for (i = 0; i < j; i++) > - free_any_clusters(bs, old_cluster[i], 1); > + free_any_clusters(bs, be64_to_cpu(old_cluster[i]), 1); > > ret = 0; > err: