From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N5ykL-0006uW-Nl
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 04:35:13 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N5ykG-0006ty-LY
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 04:35:12 -0500
Received: from [199.232.76.173] (port=46700 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N5ykG-0006tv-BD
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 04:35:08 -0500
Received: from lo.gmane.org ([80.91.229.12]:38523)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1N5ykF-0007mo-Ty
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 04:35:08 -0500
Received: from list by lo.gmane.org with local (Exim 4.50) id 1N5ykB-0005LH-Gz
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 10:35:03 +0100
Received: from nat-pool-brq-t.redhat.com ([209.132.186.34])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 05 Nov 2009 10:35:03 +0100
Received: from pbonzini by nat-pool-brq-t.redhat.com with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 05 Nov 2009 10:35:03 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 05 Nov 2009 10:34:33 +0100
Message-ID: <hcu679$6mi$1@ger.gmane.org>
References: <1257365047-25895-1-git-send-email-lcapitulino@redhat.com>
	<1257365047-25895-6-git-send-email-lcapitulino@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <1257365047-25895-6-git-send-email-lcapitulino@redhat.com>
Sender: news <news@ger.gmane.org>
Subject: [Qemu-devel] Re: [PATCH 5/8] Introduce QError
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 11/04/2009 09:04 PM, Luiz Capitulino wrote:
> +#define QERR_DEV_NFOUND "DeviceNotFound"
> +#define QERR_SER_UNAV   "ServiceUnavailable"

I don't like packing names this way (what's wrong with DEVICE_NOT_FOUND 
and SERVICE_UNAVAILABLE?...), but otherwise the series looks fine.

Paolo