From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N8pnN-0005t2-Op
	for qemu-devel@nongnu.org; Fri, 13 Nov 2009 01:38:09 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N8pnI-0005q1-WE
	for qemu-devel@nongnu.org; Fri, 13 Nov 2009 01:38:08 -0500
Received: from [199.232.76.173] (port=58571 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N8pnI-0005pj-KT
	for qemu-devel@nongnu.org; Fri, 13 Nov 2009 01:38:04 -0500
Received: from lo.gmane.org ([80.91.229.12]:40123)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1N8pnI-0007DX-8Q
	for qemu-devel@nongnu.org; Fri, 13 Nov 2009 01:38:04 -0500
Received: from list by lo.gmane.org with local (Exim 4.50) id 1N8pnF-0002j3-Jv
	for qemu-devel@nongnu.org; Fri, 13 Nov 2009 07:38:01 +0100
Received: from c83-248-35-105.bredband.comhem.se ([83.248.35.105])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Fri, 13 Nov 2009 07:38:01 +0100
Received: from pbonzini by c83-248-35-105.bredband.comhem.se with local
	(Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Fri, 13 Nov 2009 07:38:01 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Fri, 13 Nov 2009 07:37:39 +0100
Message-ID: <hdiurj$g0v$1@ger.gmane.org>
References: <1258059195-17582-1-git-send-email-agraf@suse.de>
	<1258059195-17582-6-git-send-email-agraf@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <1258059195-17582-6-git-send-email-agraf@suse.de>
Sender: news <news@ger.gmane.org>
Subject: [Qemu-devel] Re: [PATCH 5/6] Convert linux bootrom to external rom
	and fw_cfg
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 11/12/2009 09:53 PM, Alexander Graf wrote:
> +	/* Set DS to SS+SP - 0x10, so we can write our GDT descriptor there */
> +	mov		%ss, %eax
> +	shl		$4, %eax
> +	add		%esp, %eax
> +	sub		$0x10, %eax
> +	shr		$4, %eax

Dead code?  Or wrong comment and missing mov %eax, %gs?

Also, I know this is running with disabled interrupts, but why set %gs 
just below the stack instead of decrementing %esp?

> +	/* Now create the GDT descriptor */
> +	mov		%cs, %eax

Paolo