From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NB6cR-00075g-3s
	for qemu-devel@nongnu.org; Thu, 19 Nov 2009 08:00:15 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NB6cL-00072o-9y
	for qemu-devel@nongnu.org; Thu, 19 Nov 2009 08:00:13 -0500
Received: from [199.232.76.173] (port=59884 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NB6cK-00072c-S5
	for qemu-devel@nongnu.org; Thu, 19 Nov 2009 08:00:08 -0500
Received: from lo.gmane.org ([80.91.229.12]:50524)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1NB6cK-0008BF-DK
	for qemu-devel@nongnu.org; Thu, 19 Nov 2009 08:00:08 -0500
Received: from list by lo.gmane.org with local (Exim 4.50) id 1NB6cH-0007Qr-Uq
	for qemu-devel@nongnu.org; Thu, 19 Nov 2009 14:00:05 +0100
Received: from nat-pool-brq-t.redhat.com ([209.132.186.34])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 19 Nov 2009 14:00:05 +0100
Received: from pbonzini by nat-pool-brq-t.redhat.com with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 19 Nov 2009 14:00:05 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 19 Nov 2009 13:59:40 +0100
Message-ID: <he3ffs$epv$1@ger.gmane.org>
References: <1258487037-24950-1-git-send-email-lcapitulino@redhat.com>	<1258487037-24950-8-git-send-email-lcapitulino@redhat.com>	<m34oorg8xw.fsf@crossbow.pond.sub.org>	<20091118152357.2d1dc535@doriath>
	<m38we2aoss.fsf@crossbow.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <m38we2aoss.fsf@crossbow.pond.sub.org>
Sender: news <news@ger.gmane.org>
Subject: [Qemu-devel] Re: [PATCH 07/10] Introduce QError
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 11/19/2009 09:42 AM, Markus Armbruster wrote:
>> >
>> >    It's probably convenient to have qjson emitting QError, I'm unsure
>> >  if we should do that for all kinds of QObjects though.
>
> For a general purpose system, I'd recommend to cover all types.  But as
> long as this has just one user (QEMU), it can use the special purpose
> excuse not to.

You're not sending QErrors on the wire yet, are you?  Once you do, I 
suspect it will be easiest to handle to_json for QError too (or make it 
a virtual method as it was in my patches...).

Paolo