qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCHv2][SEABIOS] Make SMBIOS table pass MS SVVP test
Date: Mon, 23 Nov 2009 18:55:07 +0100	[thread overview]
Message-ID: <heei9r$52i$1@ger.gmane.org> (raw)
In-Reply-To: <20091123120318.GK2999@redhat.com>

On 11/23/2009 01:03 PM, Gleb Natapov wrote:
>       p->bios_characteristics[0] = 0x08; /* BIOS characteristics not supported */

FWIW, I agree with not changing this.

 From reading the spec, it seems like the characteristics extensions are 
totally separate from the basic characteristics, and setting bit 3 as 
done above does not mean that the extensions should also be zero.

Paolo

  reply	other threads:[~2009-11-23 17:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23 12:03 [Qemu-devel] [PATCHv2][SEABIOS] Make SMBIOS table pass MS SVVP test Gleb Natapov
2009-11-23 17:55 ` Paolo Bonzini [this message]
2009-12-11  1:15 ` [Qemu-devel] " Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='heei9r$52i$1@ger.gmane.org' \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).