From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCd8U-00081f-VV
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 12:55:40 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCd8P-0007zL-1l
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 12:55:37 -0500
Received: from [199.232.76.173] (port=52929 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCd8O-0007z8-Cj
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 12:55:32 -0500
Received: from lo.gmane.org ([80.91.229.12]:52154)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1NCd8N-0004a7-Pc
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 12:55:32 -0500
Received: from list by lo.gmane.org with local (Exim 4.50) id 1NCd8L-0000dg-KV
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 18:55:29 +0100
Received: from nat-pool-brq-t.redhat.com ([209.132.186.34])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Mon, 23 Nov 2009 18:55:29 +0100
Received: from pbonzini by nat-pool-brq-t.redhat.com with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Mon, 23 Nov 2009 18:55:29 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Mon, 23 Nov 2009 18:55:07 +0100
Message-ID: <heei9r$52i$1@ger.gmane.org>
References: <20091123120318.GK2999@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <20091123120318.GK2999@redhat.com>
Sender: news <news@ger.gmane.org>
Subject: [Qemu-devel] Re: [PATCHv2][SEABIOS] Make SMBIOS table pass MS SVVP
	test
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 11/23/2009 01:03 PM, Gleb Natapov wrote:
>       p->bios_characteristics[0] = 0x08; /* BIOS characteristics not supported */

FWIW, I agree with not changing this.

 From reading the spec, it seems like the characteristics extensions are 
totally separate from the basic characteristics, and setting bit 3 as 
done above does not mean that the extensions should also be zero.

Paolo