From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NKpyr-0001pe-Ak
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 04:15:37 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NKpym-0001ku-5n
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 04:15:36 -0500
Received: from [199.232.76.173] (port=42711 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NKpym-0001kl-0V
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 04:15:32 -0500
Received: from lo.gmane.org ([80.91.229.12]:34164)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1NKpyl-000876-Kb
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 04:15:31 -0500
Received: from list by lo.gmane.org with local (Exim 4.50) id 1NKpyj-0000yU-Ag
	for qemu-devel@nongnu.org; Wed, 16 Dec 2009 10:15:29 +0100
Received: from 85.93.118.17 ([85.93.118.17])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 16 Dec 2009 10:15:29 +0100
Received: from pbonzini by 85.93.118.17 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 16 Dec 2009 10:15:29 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Wed, 16 Dec 2009 10:15:07 +0100
Message-ID: <hga8er$7fd$1@ger.gmane.org>
References: <1260839404-28622-1-git-send-email-kirill@shutemov.name>	<cc557aab0912151148v2a98d2b2n7dd67fdb23388cd6@mail.gmail.com>	<m36388neii.fsf@neno.neno>
	<cc557aab0912160045l312a9554sbf9fc56372ed1a05@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <cc557aab0912160045l312a9554sbf9fc56372ed1a05@mail.gmail.com>
Sender: news <news@ger.gmane.org>
Subject: [Qemu-devel] Re: [PATCH] Fix TEXTREL in user targets when compiled
	with --enable-user-pie
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 12/16/2009 09:45 AM, Kirill A. Shutemov wrote:
>>>> >>>  -VPATH=$(SRC_PATH)
>>>> >>>  +vpath %.c $(SRC_PATH)
>> >
>> >  This change is needed?
> Yes. We dont want to take %.o from $(SRC_PATH) since they built without -fpie.

I think that's fine, it's kind of the purpose of vpath to only look for 
sources in the vpath; so it's safer to use "vpath" than "VPATH".  That 
said, I'd change it to

vpath %.c %.h $(SRC_PATH)

and I'd do so uniformly in all the directories that currently use VPATH.

Paolo