From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NWpv2-0004VK-GV
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:37:16 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NWpuw-0004T1-W1
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:37:15 -0500
Received: from [199.232.76.173] (port=59023 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NWpuw-0004So-9d
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:37:10 -0500
Received: from lo.gmane.org ([80.91.229.12]:37012)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1NWput-0006O9-VQ
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 06:37:08 -0500
Received: from list by lo.gmane.org with local (Exim 4.50) id 1NWpuh-00032a-2Y
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 12:36:55 +0100
Received: from 93-34-208-53.ip51.fastwebnet.it ([93.34.208.53])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Mon, 18 Jan 2010 12:36:55 +0100
Received: from pbonzini by 93-34-208-53.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Mon, 18 Jan 2010 12:36:55 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Mon, 18 Jan 2010 12:35:46 +0100
Message-ID: <hj1h2h$51u$1@ger.gmane.org>
References: <20100117124528.GA24106@bee.dooz.org>	<4B531244.6060702@mail.berlios.de>
	<20100117160639.GA12343@pig.zood.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
In-Reply-To: <20100117160639.GA12343@pig.zood.org>
Sender: news <news@ger.gmane.org>
Subject: [Qemu-devel] Re: [PATCH] Check for sdl-config before calling it
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 01/17/2010 05:06 PM, Loïc Minier wrote:
> On Sun, Jan 17, 2010, Stefan Weil wrote:
>>> On systems were sdl-config isn't installed, ./configure triggers this
>>> warning:
>>> ./configure: 957: sdl-config: not found
>>
>> which version did you test?
>> Git master has no sdl-config call at configure:957.
>>
>> But I get warning messages, too, when pkg-config or
>> sdl-config are missing.
>
>   Yes, the line is bogus for me as well; not sure why.  I'm using master.
>
>> Your patch fixes the warning for sdl-config and sets
>> sdl=no. If configure was called with --enable-sdl,
>> this solution is wrong: configure should abort with
>> an error message (feature_not_found).
>
>   Ack; how about the attached one instead?

Acked-By: Paolo Bonzini <pbonzini@redhat.com>

Paolo