From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZ3ix-0001FN-OW
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 09:45:59 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZ3it-0001Bd-V1
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 09:45:59 -0500
Received: from [199.232.76.173] (port=50134 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZ3it-0001BQ-CI
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 09:45:55 -0500
Received: from mx20.gnu.org ([199.232.41.8]:3660)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1NZ3it-0007Bd-4A
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 09:45:55 -0500
Received: from lo.gmane.org ([80.91.229.12])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1NZ3iq-0004XP-O7
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 09:45:52 -0500
Received: from list by lo.gmane.org with local (Exim 4.50) id 1NZ3im-0006G7-TU
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 15:45:48 +0100
Received: from 93-34-208-53.ip51.fastwebnet.it ([93.34.208.53])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Sun, 24 Jan 2010 15:45:48 +0100
Received: from pbonzini by 93-34-208-53.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Sun, 24 Jan 2010 15:45:48 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Sun, 24 Jan 2010 15:45:28 +0100
Message-ID: <hjhme7$ht7$1@ger.gmane.org>
References: <1264342938-7363-1-git-send-email-aliguori@us.ibm.com>
	<1264342938-7363-2-git-send-email-aliguori@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <1264342938-7363-2-git-send-email-aliguori@us.ibm.com>
Sender: news <news@ger.gmane.org>
Subject: [Qemu-devel] Re: [PATCH 1/3] Support --sysconfdir in configure to
 specify path to configuration files (v3)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 01/24/2010 03:22 PM, Anthony Liguori wrote:
> The default value is ${prefix}/etc/qemu.  --sysconfdir can be used to override
> the default to an absolute path.  The expectation is that when installed to
> /usr, --sysconfdir=/etc/qemu will be used.
>
> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
> ---
> v2 ->  v3
>   - default sysconfdir to ${prefix}/etc on unix, ${prefix} on win32
>   - set confdir to ${sysconfdir}/qemu on unix, ${sysconfdir} on win32

I'm not sure about the choice for Windows.  Do we want possibly a dozen 
of .conf files all in the same directory as the binaries, or maybe it's 
better to set sysconfdir = ${prefix}/conf, confdir=${sysconfdir} on Windows?

> +if test "$mingw32" = "yes" ; then
> +  echo "CONFIG_QEMU_CONFDIR=\"$sysconfdir\"" >> $config_host_mak
> +else
> +  echo "CONFIG_QEMU_CONFDIR=\"${sysconfdir}/qemu\"" >> $config_host_mak
> +fi

Also, here you can use $confsuffix as used a bit above to avoid 
introducing an if here.

Anyway, this can be discussed/cleaned up later, this patch gets my ack.

Paolo