From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NdLsQ-00018Y-Rs
	for qemu-devel@nongnu.org; Fri, 05 Feb 2010 05:57:30 -0500
Received: from [199.232.76.173] (port=34251 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NdLsP-00017c-Ku
	for qemu-devel@nongnu.org; Fri, 05 Feb 2010 05:57:29 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1NdLsO-0002aT-N7
	for qemu-devel@nongnu.org; Fri, 05 Feb 2010 05:57:29 -0500
Received: from lo.gmane.org ([80.91.229.12]:49710)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1NdLsO-0002aJ-Bl
	for qemu-devel@nongnu.org; Fri, 05 Feb 2010 05:57:28 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1NdLpx-0003nG-95
	for qemu-devel@nongnu.org; Fri, 05 Feb 2010 11:54:57 +0100
Received: from 93-34-208-53.ip51.fastwebnet.it ([93.34.208.53])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Fri, 05 Feb 2010 11:54:57 +0100
Received: from pbonzini by 93-34-208-53.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Fri, 05 Feb 2010 11:54:57 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Fri, 05 Feb 2010 09:47:42 +0100
Message-ID: <hkglvc$qgg$1@ger.gmane.org>
References: <201002042313.45353.sheng@linux.intel.com>	<1265298599-4186-1-git-send-email-pbonzini@redhat.com>
	<201002051026.10614.sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <201002051026.10614.sheng@linux.intel.com>
Sender: news <news@ger.gmane.org>
Subject: [Qemu-devel] Re: [PATCH 0/4] Fix printf calls embedding
	preprocessor directives
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 02/05/2010 03:26 AM, Sheng Yang wrote:
> -#ifndef _WIN32
> -           DEFAULT_NETWORK_SCRIPT,
> -           DEFAULT_NETWORK_DOWN_SCRIPT,
> -#endif
> -           DEFAULT_GDBSTUB_PORT,
> -           "/tmp/qemu.log");
> +           "qemu");
>       exit(exitcode);
>   }
>
> Is it proper to remove #ifndef _WIN32 there?

Yes, this matched a #ifndef in qemu-options.hx that remains there.

Paolo