From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nwhbs-00005m-02
	for qemu-devel@nongnu.org; Tue, 30 Mar 2010 16:00:24 -0400
Received: from [140.186.70.92] (port=50745 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nwhbn-0008Th-K6
	for qemu-devel@nongnu.org; Tue, 30 Mar 2010 16:00:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1Nwhbj-0001I0-AY
	for qemu-devel@nongnu.org; Tue, 30 Mar 2010 16:00:18 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:32839)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1Nwhbi-0001Hm-Md
	for qemu-devel@nongnu.org; Tue, 30 Mar 2010 16:00:15 -0400
Received: by pwi6 with SMTP id 6so553391pwi.4
	for <qemu-devel@nongnu.org>; Tue, 30 Mar 2010 13:00:13 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20100330192855.GA24846@8bytes.org>
References: <cover.1269936879.git.eduard.munteanu@linux360.ro>
	<d9001abc473c4c13180637d00643cbafc587e13a.1269936879.git.eduard.munteanu@linux360.ro>
	<f43fc5581003301006o450c6de9rbb591f1b15729d36@mail.gmail.com>
	<20100330192855.GA24846@8bytes.org>
Date: Tue, 30 Mar 2010 23:00:10 +0300
Message-ID: <i2gf43fc5581003301300m7019f68em53341d00af6d2dca@mail.gmail.com>
Subject: Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Joerg Roedel <joro@8bytes.org>
Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, avi@redhat.com, kvm@vger.kernel.org, Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>

On 3/30/10, Joerg Roedel <joro@8bytes.org> wrote:
> On Tue, Mar 30, 2010 at 08:06:36PM +0300, Blue Swirl wrote:
>  > On 3/30/10, Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> wrote:
>  > > hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the
>  > >  AMD IOMMU, which could lead to confusion unless we rename the former.
>  >
>  > I was also thinking of renaming the file some time ago. The correct
>  > name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a
>  > different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had
>  > several IO-UNITs instead. All Sun4m machines had an IOMMU.
>  >
>  > But the qdev name of the device is still "iommu" and we can't change
>  > that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside
>  > in amd_iommu.c?
>
>
> Keeping the plain name 'iommu' will likely cause confusion when more
>  iommu implementations are added. It is better to rename it so that the
>  name better describes what the file implements. So this change makes
>  sense for me.

I see. I'm OK then with "sun4m_iommu.c".