From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O1021-00071d-PJ for qemu-devel@nongnu.org; Sun, 11 Apr 2010 12:29:09 -0400 Received: from [140.186.70.92] (port=51061 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O1020-00071O-EA for qemu-devel@nongnu.org; Sun, 11 Apr 2010 12:29:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O101y-0002l1-KH for qemu-devel@nongnu.org; Sun, 11 Apr 2010 12:29:08 -0400 Received: from mail-pz0-f204.google.com ([209.85.222.204]:50099) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O101y-0002kr-Bl for qemu-devel@nongnu.org; Sun, 11 Apr 2010 12:29:06 -0400 Received: by pzk42 with SMTP id 42so3271419pzk.4 for ; Sun, 11 Apr 2010 09:29:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20100408012729.GA8872@amt.cnet> References: <4BBC4CC6.7060705@bandsman.co.uk> <20100408012729.GA8872@amt.cnet> Date: Sun, 11 Apr 2010 19:29:04 +0300 Message-ID: Subject: Re: [Qemu-devel] Latest Git fails to compile in cpus.c From: Blue Swirl Content-Type: multipart/mixed; boundary=000e0cd0ebd0d8f62f0483f88683 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti Cc: Nigel Horne , qemu-devel@nongnu.org --000e0cd0ebd0d8f62f0483f88683 Content-Type: text/plain; charset=UTF-8 On 4/8/10, Marcelo Tosatti wrote: > On Wed, Apr 07, 2010 at 09:02:53PM +0300, Blue Swirl wrote: > > On 4/7/10, malc wrote: > > > On Wed, 7 Apr 2010, Nigel Horne wrote: > > > > > > > ./configure --enable-linux-aio --enable-io-thread --enable-kvm: > > > > > > > > .... > > > > > > > > /home/njh/src/qemu/cpus.c:360: error: ?SIG_IPI? undeclared (first use in this > > > > function) > > > > /home/njh/src/qemu/cpus.c:360: error: (Each undeclared identifier is reported > > > > only once > > > > > > > > > And even if one defines that things will still not work due to: > > > .../cpus.c:657: error: 'vmstop_requested' undeclared (first use in this function) > > > > > > IOW --enable-io-thread is broken as it is now. > > > > Didn't anybody test the patch I sent: > > http://lists.gnu.org/archive/html/qemu-devel/2010-04/msg00051.html > > > > > The broadcast must be signalled after the machine is fully initialized. I made a new version which does not change the call sequence. --000e0cd0ebd0d8f62f0483f88683 Content-Type: text/x-diff; charset=US-ASCII; name="0001-Fix-build-when-configured-with-enable-io-thread.patch" Content-Disposition: attachment; filename="0001-Fix-build-when-configured-with-enable-io-thread.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g7w2jmw5 RnJvbSBjYWQzNzA1MmM3ZGQyYTdhNTcyNjE0YjYyZDc2ZDlmMmU4YTJhNDA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCbHVlIFN3aXJsIDxibGF1d2lyYmVsQGdtYWlsLmNvbT4KRGF0 ZTogU3VuLCAxMSBBcHIgMjAxMCAxNjoyNjo1NCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBi dWlsZCB3aGVuIGNvbmZpZ3VyZWQgd2l0aCAtLWVuYWJsZS1pby10aHJlYWQKClNpZ25lZC1vZmYt Ynk6IEJsdWUgU3dpcmwgPGJsYXV3aXJiZWxAZ21haWwuY29tPgotLS0KIGNwdXMuYyB8ICAgMTYg KysrKysrKysrKysrKysrKwogY3B1cy5oIHwgICAgNCArKystCiB2bC5jICAgfCAgIDEzICsrLS0t LS0tLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvY3B1cy5jIGIvY3B1cy5jCmluZGV4IDBkZWJlNzcuLjg0NTBlZTQg MTAwNjQ0Ci0tLSBhL2NwdXMuYworKysgYi9jcHVzLmMKQEAgLTMzLDYgKzMzLDEyIEBACiAKICNp bmNsdWRlICJjcHVzLmgiCiAKKyNpZmRlZiBTSUdSVE1JTgorI2RlZmluZSBTSUdfSVBJIChTSUdS VE1JTis0KQorI2Vsc2UKKyNkZWZpbmUgU0lHX0lQSSBTSUdVU1IxCisjZW5kaWYKKwogc3RhdGlj IENQVVN0YXRlICpjdXJfY3B1Owogc3RhdGljIENQVVN0YXRlICpuZXh0X2NwdTsKIApAQCAtMjI2 LDYgKzIzMiwxMCBAQCBpbnQgcWVtdV9pbml0X21haW5fbG9vcCh2b2lkKQogICAgIHJldHVybiBx ZW11X2V2ZW50X2luaXQoKTsKIH0KIAordm9pZCBxZW11X21haW5fbG9vcF9zdGFydCh2b2lkKQor eworfQorCiB2b2lkIHFlbXVfaW5pdF92Y3B1KHZvaWQgKl9lbnYpCiB7CiAgICAgQ1BVU3RhdGUg KmVudiA9IF9lbnY7CkBAIC0zMTgsNiArMzI4LDEyIEBAIGludCBxZW11X2luaXRfbWFpbl9sb29w KHZvaWQpCiAgICAgcmV0dXJuIDA7CiB9CiAKK3ZvaWQgcWVtdV9tYWluX2xvb3Bfc3RhcnQodm9p ZCkKK3sKKyAgICBxZW11X3N5c3RlbV9yZWFkeSA9IDE7CisgICAgcWVtdV9jb25kX2Jyb2FkY2Fz dCgmcWVtdV9zeXN0ZW1fY29uZCk7Cit9CisKIHN0YXRpYyB2b2lkIHFlbXVfd2FpdF9pb19ldmVu dF9jb21tb24oQ1BVU3RhdGUgKmVudikKIHsKICAgICBpZiAoZW52LT5zdG9wKSB7CmRpZmYgLS1n aXQgYS9jcHVzLmggYi9jcHVzLmgKaW5kZXggNjdjOWEzYi4uNGViYWQzYSAxMDA2NDQKLS0tIGEv Y3B1cy5oCisrKyBiL2NwdXMuaApAQCAtMSw4ICsxLDkgQEAKICNpZm5kZWYgUUVNVV9DUFVTX0gK ICNkZWZpbmUgUUVNVV9DUFVTX0gKIAotLyogY3B1LWNvbW1vbi5jICovCisvKiBjcHVzLmMgKi8K IGludCBxZW11X2luaXRfbWFpbl9sb29wKHZvaWQpOwordm9pZCBxZW11X21haW5fbG9vcF9zdGFy dCh2b2lkKTsKIHZvaWQgcmVzdW1lX2FsbF92Y3B1cyh2b2lkKTsKIHZvaWQgcGF1c2VfYWxsX3Zj cHVzKHZvaWQpOwogCkBAIC0xMCw2ICsxMSw3IEBAIHZvaWQgcGF1c2VfYWxsX3ZjcHVzKHZvaWQp OwogZXh0ZXJuIGludCBzbXBfY29yZXM7CiBleHRlcm4gaW50IHNtcF90aHJlYWRzOwogZXh0ZXJu IGludCBkZWJ1Z19yZXF1ZXN0ZWQ7CitleHRlcm4gaW50IHZtc3RvcF9yZXF1ZXN0ZWQ7CiB2b2lk IHZtX3N0YXRlX25vdGlmeShpbnQgcnVubmluZywgaW50IHJlYXNvbik7CiBib29sIHRjZ19jcHVf ZXhlYyh2b2lkKTsKIHZvaWQgc2V0X251bWFfbW9kZXModm9pZCk7CmRpZmYgLS1naXQgYS92bC5j IGIvdmwuYwppbmRleCBlYTc5YWM0Li40ZmI1NWI4IDEwMDY0NAotLS0gYS92bC5jCisrKyBiL3Zs LmMKQEAgLTI0NCwxMiArMjQ0LDYgQEAgaW50IGt2bV9hbGxvd2VkID0gMDsKIHVpbnQzMl90IHhl bl9kb21pZDsKIGVudW0geGVuX21vZGUgeGVuX21vZGUgPSBYRU5fRU1VTEFURTsKIAotI2lmZGVm IFNJR1JUTUlOCi0jZGVmaW5lIFNJR19JUEkgKFNJR1JUTUlOKzQpCi0jZWxzZQotI2RlZmluZSBT SUdfSVBJIFNJR1VTUjEKLSNlbmRpZgotCiBzdGF0aWMgaW50IGRlZmF1bHRfc2VyaWFsID0gMTsK IHN0YXRpYyBpbnQgZGVmYXVsdF9wYXJhbGxlbCA9IDE7CiBzdGF0aWMgaW50IGRlZmF1bHRfdmly dGNvbiA9IDE7CkBAIC0xNzE3LDcgKzE3MTEsNyBAQCBzdGF0aWMgaW50IHJlc2V0X3JlcXVlc3Rl ZDsKIHN0YXRpYyBpbnQgc2h1dGRvd25fcmVxdWVzdGVkOwogc3RhdGljIGludCBwb3dlcmRvd25f cmVxdWVzdGVkOwogaW50IGRlYnVnX3JlcXVlc3RlZDsKLXN0YXRpYyBpbnQgdm1zdG9wX3JlcXVl c3RlZDsKK2ludCB2bXN0b3BfcmVxdWVzdGVkOwogCiBpbnQgcWVtdV9zaHV0ZG93bl9yZXF1ZXN0 ZWQodm9pZCkKIHsKQEAgLTE5NTUsMTAgKzE5NDksNyBAQCBzdGF0aWMgdm9pZCBtYWluX2xvb3Ao dm9pZCkKIHsKICAgICBpbnQgcjsKIAotI2lmZGVmIENPTkZJR19JT1RIUkVBRAotICAgIHFlbXVf c3lzdGVtX3JlYWR5ID0gMTsKLSAgICBxZW11X2NvbmRfYnJvYWRjYXN0KCZxZW11X3N5c3RlbV9j b25kKTsKLSNlbmRpZgorICAgIHFlbXVfbWFpbl9sb29wX3N0YXJ0KCk7CiAKICAgICBmb3IgKDs7 KSB7CiAgICAgICAgIGRvIHsKLS0gCjEuNS42LjUKCg== --000e0cd0ebd0d8f62f0483f88683--