From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60781 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdmYt-0000b3-N1
	for qemu-devel@nongnu.org; Fri, 14 Jan 2011 11:31:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1PdmYU-0005WE-1L
	for qemu-devel@nongnu.org; Fri, 14 Jan 2011 11:31:16 -0500
Received: from lo.gmane.org ([80.91.229.12]:37354)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1PdmYT-0005Vo-Rt
	for qemu-devel@nongnu.org; Fri, 14 Jan 2011 11:31:13 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1PdmYP-00079B-IN
	for qemu-devel@nongnu.org; Fri, 14 Jan 2011 17:31:09 +0100
Received: from 93-34-149-100.ip50.fastwebnet.it ([93.34.149.100])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Fri, 14 Jan 2011 17:31:09 +0100
Received: from pbonzini by 93-34-149-100.ip50.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Fri, 14 Jan 2011 17:31:09 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Fri, 14 Jan 2011 17:30:50 +0100
Message-ID: <igptnq$iao$1@dough.gmane.org>
References: <1295006132-29153-1-git-send-email-kraxel@redhat.com>
	<1295006132-29153-3-git-send-email-kraxel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <1295006132-29153-3-git-send-email-kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 2/7] usb keyboard: add event event queue
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 01/14/2011 12:55 PM, Gerd Hoffmann wrote:
> This patch adds a event queue to the usb keyboard.  This makes sure the
> guest will see all key events even if they come in bursts.  With this
> patch applied sending Ctrl-Alt-Del using vncviewer's F8 menu works.
> Also with autosuspend enabled the first keypress on a suspended keyboard
> takes a little longer to be delivered to the guest because the usb bus
> must be resumed first.  Without event queue this easily gets lost.
>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>   hw/usb-hid.c |   38 ++++++++++++++++++++++++++++++++------
>   1 files changed, 32 insertions(+), 6 deletions(-)

Nice elegant patch.

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo