qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] lsi: Fix unused-but-set-variable warning
Date: Wed, 01 Jun 2011 16:19:51 +0200	[thread overview]
Message-ID: <is5hq7$gdl$1@dough.gmane.org> (raw)
In-Reply-To: <1306932992-30075-2-git-send-email-cfergeau@redhat.com>

On 06/01/2011 02:56 PM, Christophe Fergeau wrote:
> This warning is new in gcc 4.6.
>
> Signed-off-by: Christophe Fergeau<cfergeau@redhat.com>
> ---
>   hw/lsi53c895a.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
> index 83084b6..90c6cbc 100644
> --- a/hw/lsi53c895a.c
> +++ b/hw/lsi53c895a.c
> @@ -889,7 +889,6 @@ static void lsi_do_msgout(LSIState *s)
>       uint8_t msg;
>       int len;
>       uint32_t current_tag;
> -    SCSIDevice *current_dev;
>       lsi_request *current_req, *p, *p_next;
>       int id;
>
> @@ -901,7 +900,6 @@ static void lsi_do_msgout(LSIState *s)
>           current_req = lsi_find_by_tag(s, current_tag);
>       }
>       id = (current_tag>>  8)&  0xf;
> -    current_dev = s->bus.devs[id];
>
>       DPRINTF("MSG out len=%d\n", s->dbc);
>       while (s->dbc) {

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

  reply	other threads:[~2011-06-02  1:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 12:56 [Qemu-devel] [PATCH 0/3] Fix unused-but-set-variable warnings Christophe Fergeau
2011-06-01 12:56 ` [Qemu-devel] [PATCH 1/3] lsi: Fix unused-but-set-variable warning Christophe Fergeau
2011-06-01 14:19   ` Paolo Bonzini [this message]
2011-06-10 16:36     ` Peter Maydell
2011-06-10 19:21       ` Richard Henderson
2011-06-10 18:45   ` Stefan Hajnoczi
2011-06-01 12:56 ` [Qemu-devel] [PATCH 2/3] ehci: " Christophe Fergeau
2011-06-01 15:53   ` David Ahern
2011-06-01 16:21     ` Christophe Fergeau
2011-06-01 12:56 ` [Qemu-devel] [PATCH 3/3] linux-user: " Christophe Fergeau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='is5hq7$gdl$1@dough.gmane.org' \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).