From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning
Date: Thu, 15 Sep 2011 14:08:20 +0200 [thread overview]
Message-ID: <j4sprk$mjr$1@dough.gmane.org> (raw)
In-Reply-To: <1316085356-632-1-git-send-email-peter.maydell@linaro.org>
On 09/15/2011 01:15 PM, Peter Maydell wrote:
> If pkg-config doesn't exist then make configure fail immediately
> with a useful error message. Now that glib is a required dependency,
> proceeding despite the missing pkg-config will just cause us to
> fail later with a misleading message about glib not being present.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> configure | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 0875f95..6c2839d 100755
> --- a/configure
> +++ b/configure
> @@ -1339,8 +1339,8 @@ fi
> # pkg-config probe
>
> if ! has $pkg_config; then
> - echo warning: proceeding without "$pkg_config">&2
> - pkg_config=/bin/false
> + echo "Error: pkg-config binary '$pkg_config' not found"
> + exit 1
> fi
>
> ##########################################
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2011-09-15 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 11:15 [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning Peter Maydell
2011-09-15 12:08 ` Paolo Bonzini [this message]
2011-09-15 12:25 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='j4sprk$mjr$1@dough.gmane.org' \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).