From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58902)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1R4AkF-0000uY-2f
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 08:08:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1R4AkD-0003hY-SL
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 08:08:43 -0400
Received: from lo.gmane.org ([80.91.229.12]:56262)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1R4AkD-0003hG-Fx
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 08:08:41 -0400
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1R4Ak5-00036b-TM
	for qemu-devel@nongnu.org; Thu, 15 Sep 2011 14:08:33 +0200
Received: from 93-34-199-31.ip51.fastwebnet.it ([93.34.199.31])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 15 Sep 2011 14:08:33 +0200
Received: from pbonzini by 93-34-199-31.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 15 Sep 2011 14:08:33 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 15 Sep 2011 14:08:20 +0200
Message-ID: <j4sprk$mjr$1@dough.gmane.org>
References: <1316085356-632-1-git-send-email-peter.maydell@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <1316085356-632-1-git-send-email-peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] configure: Make missing pkg-config an
 error rather than a warning
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 09/15/2011 01:15 PM, Peter Maydell wrote:
> If pkg-config doesn't exist then make configure fail immediately
> with a useful error message. Now that glib is a required dependency,
> proceeding despite the missing pkg-config will just cause us to
> fail later with a misleading message about glib not being present.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   configure |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 0875f95..6c2839d 100755
> --- a/configure
> +++ b/configure
> @@ -1339,8 +1339,8 @@ fi
>   # pkg-config probe
>
>   if ! has $pkg_config; then
> -  echo warning: proceeding without "$pkg_config">&2
> -  pkg_config=/bin/false
> +  echo "Error: pkg-config binary '$pkg_config' not found"
> +  exit 1
>   fi
>
>   ##########################################

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo