* [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning
@ 2011-09-15 11:15 Peter Maydell
2011-09-15 12:08 ` Paolo Bonzini
2011-09-15 12:25 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2011-09-15 11:15 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
If pkg-config doesn't exist then make configure fail immediately
with a useful error message. Now that glib is a required dependency,
proceeding despite the missing pkg-config will just cause us to
fail later with a misleading message about glib not being present.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
configure | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 0875f95..6c2839d 100755
--- a/configure
+++ b/configure
@@ -1339,8 +1339,8 @@ fi
# pkg-config probe
if ! has $pkg_config; then
- echo warning: proceeding without "$pkg_config" >&2
- pkg_config=/bin/false
+ echo "Error: pkg-config binary '$pkg_config' not found"
+ exit 1
fi
##########################################
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning
2011-09-15 11:15 [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning Peter Maydell
@ 2011-09-15 12:08 ` Paolo Bonzini
2011-09-15 12:25 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2011-09-15 12:08 UTC (permalink / raw)
To: qemu-devel
On 09/15/2011 01:15 PM, Peter Maydell wrote:
> If pkg-config doesn't exist then make configure fail immediately
> with a useful error message. Now that glib is a required dependency,
> proceeding despite the missing pkg-config will just cause us to
> fail later with a misleading message about glib not being present.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> configure | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 0875f95..6c2839d 100755
> --- a/configure
> +++ b/configure
> @@ -1339,8 +1339,8 @@ fi
> # pkg-config probe
>
> if ! has $pkg_config; then
> - echo warning: proceeding without "$pkg_config">&2
> - pkg_config=/bin/false
> + echo "Error: pkg-config binary '$pkg_config' not found"
> + exit 1
> fi
>
> ##########################################
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Make missing pkg-config an error rather than a warning
2011-09-15 11:15 [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning Peter Maydell
2011-09-15 12:08 ` Paolo Bonzini
@ 2011-09-15 12:25 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2011-09-15 12:25 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On Thu, Sep 15, 2011 at 12:15:56PM +0100, Peter Maydell wrote:
> If pkg-config doesn't exist then make configure fail immediately
> with a useful error message. Now that glib is a required dependency,
> proceeding despite the missing pkg-config will just cause us to
> fail later with a misleading message about glib not being present.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> configure | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-15 12:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-15 11:15 [Qemu-devel] [PATCH] configure: Make missing pkg-config an error rather than a warning Peter Maydell
2011-09-15 12:08 ` Paolo Bonzini
2011-09-15 12:25 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).