From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJOTH-0006NU-IY for qemu-devel@nongnu.org; Thu, 27 Oct 2011 07:50:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJOTG-0000v6-LD for qemu-devel@nongnu.org; Thu, 27 Oct 2011 07:50:07 -0400 Received: from lo.gmane.org ([80.91.229.12]:53737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJOTG-0000u8-Ee for qemu-devel@nongnu.org; Thu, 27 Oct 2011 07:50:06 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1RJOTF-0002bC-6b for qemu-devel@nongnu.org; Thu, 27 Oct 2011 13:50:05 +0200 Received: from 93-34-199-98.ip51.fastwebnet.it ([93.34.199.98]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 27 Oct 2011 13:50:05 +0200 Received: from pbonzini by 93-34-199-98.ip51.fastwebnet.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 27 Oct 2011 13:50:05 +0200 From: Paolo Bonzini Date: Thu, 27 Oct 2011 13:46:46 +0200 Message-ID: References: <1317798728-28938-1-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In-Reply-To: <1317798728-28938-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] ping Re: [PATCH 0/6] misc vvfat fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 10/05/2011 09:12 AM, Paolo Bonzini wrote: > It occurred to me that, if there's one thing vvfat ought to be good > at, it is creating disk images with qemu-img convert (a driver disk > in my case). > > It turns out the use case is really broken. qemu-img doesn't > complete at all, the resulting images often do not pass fsck, > and it's impossible to create a 1.44 MB disk image. This > series fixes all of the small problems I found. > > Coding standard in this file is such a pain that I hardly bothered > about it. > > > Paolo Bonzini (6): > vvfat: fix out of bounds array_get usage > vvfat: do not fail if the disk has spare sectors > vvfat: need to use first_sectors_number to distinguish fdd/hdd > vvfat: unify and correct computation of sector count > vvfat: do not hardcode sector counts in error message > vvfat: reorganize computation of disk geometry > > block/vvfat.c | 50 ++++++++++++++++++++++++-------------------------- > 3 files changed, 26 insertions(+), 28 deletions(-) > ping? Paolo