From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38024)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RKooj-0006k5-FD
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 06:10:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RKooi-000873-NG
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 06:10:09 -0400
Received: from lo.gmane.org ([80.91.229.12]:46323)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RKooi-00086I-I5
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 06:10:08 -0400
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1RKoog-0005sI-KB
	for qemu-devel@nongnu.org; Mon, 31 Oct 2011 11:10:06 +0100
Received: from 93-34-199-98.ip51.fastwebnet.it ([93.34.199.98])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Mon, 31 Oct 2011 11:10:06 +0100
Received: from pbonzini by 93-34-199-98.ip51.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Mon, 31 Oct 2011 11:10:06 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Mon, 31 Oct 2011 11:05:44 +0100
Message-ID: <j8lrtm$p3q$2@dough.gmane.org>
References: <1319214405-20388-1-git-send-email-pbonzini@redhat.com>
	<1319214405-20388-4-git-send-email-pbonzini@redhat.com>
	<CAETRQW=RzJqWSHrqCyH9p50yyZx83NQ3uCe+1Vex_T+G9tsGOA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <CAETRQW=RzJqWSHrqCyH9p50yyZx83NQ3uCe+1Vex_T+G9tsGOA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to
	qemu_rearm_alarm_timer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 10/31/2011 08:23 AM, TeLeMan wrote:
>> >    static void qemu_rearm_alarm_timer(struct qemu_alarm_timer *t)
>> >    {
>> >  -    if (!alarm_has_dynticks(t))
>> >  +    int64_t nearest_delta_ns;
>> >  +    assert(alarm_has_dynticks(t));
> "mmtimer" and "win32" alarms have no rearm. Should we remove these two alarms?

Yes. I think with iothread they are broken, or almost broken.

Paolo