From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKttH-0006Hu-FC for qemu-devel@nongnu.org; Mon, 31 Oct 2011 11:35:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKttB-00035b-KG for qemu-devel@nongnu.org; Mon, 31 Oct 2011 11:35:11 -0400 Received: from lo.gmane.org ([80.91.229.12]:52435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKttB-00034A-8d for qemu-devel@nongnu.org; Mon, 31 Oct 2011 11:35:05 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1RKttA-0002LU-0W for qemu-devel@nongnu.org; Mon, 31 Oct 2011 16:35:04 +0100 Received: from 93-34-199-98.ip51.fastwebnet.it ([93.34.199.98]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 31 Oct 2011 16:35:03 +0100 Received: from pbonzini by 93-34-199-98.ip51.fastwebnet.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 31 Oct 2011 16:35:03 +0100 From: Paolo Bonzini Date: Mon, 31 Oct 2011 16:34:50 +0100 Message-ID: References: <1319811501-6823-1-git-send-email-kwolf@redhat.com> <4EAAD9B4.7040206@redhat.com> <4EAEB4A9.2000203@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In-Reply-To: <4EAEB4A9.2000203@redhat.com> Subject: Re: [Qemu-devel] [PATCH] dma: Avoid reentrancy in DMA transfer handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 10/31/2011 03:46 PM, Kevin Wolf wrote: > > Hmm, I think you should set rearm = 1 to ensure the BH is run when > > ultimately you leave the sync read. Sorry for not spotting this before. > > I was about to agree, but in fact adding a rearm = 1; line leads to > crashes, whereas in the version I posted it just works. So it looks like > something is wrong with doing it, even though it seemed to make perfect > sense at the first sight. But what will restart the DMA at the end of the synchronous I/O, then? Paolo